github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fallback to "YES" in a case of noticeable floating point numbers underflow

Browse Source
This commit is contained in:
Slava Kim
2014-01-10 17:51:54 -08:00
parent 0cfefa63d1
commit ccdbe31356
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/minimongo/minimongo_server_tests.js
View File

@@ -497,6 +497,9 @@ Tinytest.add("minimongo - selector and projection combination", function (test)
T({ a: { $lte: 10 } }, { $set: { a: -Infinity } }, "-Infinity <= 10?");
// XXX is this sufficient?
T({ a: { $gt: 9.99999999999999, $lt: 10 }, x: 1 }, { $set: { x: 1 } }, "very close $gt and $lt");
// XXX this test should be F, but since it is so hard to be precise in
// floating point math, the current implementation falls back to T
T({ a: { $gt: 9.999999999999999, $lt: 10 }, x: 1 }, { $set: { x: 1 } }, "very close $gt and $lt");
T({ a: { $ne: 5 } }, { $unset: { a: 1 } }, "unset of $ne");
T({ a: { $ne: 5 } }, { $set: { a: 1 } }, "set of $ne");
T({ a: { $ne: "some string" }, x: 1 }, { $set: { x: 1 } }, "$ne dummy");

16
packages/minimongo/selector_modifier.js
View File

@@ -85,7 +85,7 @@ Minimongo.Matcher.prototype.canBecomeTrueByModifier = function (modifier) {
// convert a selector into an object matching the selector
// { 'a.b': { ans: 42 }, 'foo.bar': null, 'foo.baz': "something" }
// => { a: { b: { ans: 42 } }, foo: { bar: null, baz: "something" } }
var failed = false;
var fallback = false;
var doc = pathsToTree(self._getPaths(),
function (path) {
var valueSelector = self._selector[path];
@@ -109,18 +109,26 @@ Minimongo.Matcher.prototype.canBecomeTrueByModifier = function (modifier) {
lowerBound = valueSelector[op];
});
return (lowerBound + upperBound) / 2;
var middle = (lowerBound + upperBound) / 2;
var matcher = new Minimongo.Matcher({ placeholder: valueSelector });
if (!matcher.documentMatches({ placeholder: middle }).result &&
(middle === lowerBound || middle === upperBound))
fallback = true;
return middle;
} else if (onlyContainsKeys(valueSelector, ['$nin',' $ne'])) {
return {};
} else {
failed = true;
fallback = true;
}
}
return self._selector[path];
},
_.identity /*conflict resolution is no resolution*/);
if (failed)
// If the analysis of this selector is too hard for our implementation
// fallback to "YES"
if (fallback)
return true;
try {