github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

wip: almost correct cost function; no estimation function as of yet

Browse Source
This commit is contained in:
Slava Kim
2014-04-23 18:57:44 -07:00
parent 6597ce4585
commit d084409eaa
1 changed files with 38 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
packages/constraint-solver/constraint-solver.js
View File

@@ -230,24 +230,38 @@ ConstraintSolver.PackagesResolver.prototype._getResolverOptions =
semver.gte(prev.version, uv.earliestCompatibleVersion) ||
semver.gte(uv.version, prev.earliestCompatibleVersion);
// XXX this is correct for root deps, branch out for transitive deps
if (versionsDistance < 0 || ! isCompatible) {
// the new pick is older or is incompatible with the prev. solution
// i.e. can have breaking changes
cost[VMAJOR]++;
if (isRootDep[uv.name]) {
// root dependency
if (versionsDistance < 0 || ! isCompatible) {
// the new pick is older or is incompatible with the prev. solution
// i.e. can have breaking changes, prefer not to do this
cost[VMAJOR]++;
} else {
// compatible but possibly newer
// prefer the version closest to the older solution
cost[MEDIUM] += versionsDistance;
}
} else {
// compatible but possibly newer
cost[MEDIUM] += versionsDistance;
// transitive dependency
// prefer to have less changed transitive dependencies
cost[MINOR] += versionsDistance === 0 ? 1 : 0;
}
} else {
// xcxc new to the solution
var latestDistance =
semverToNum(self.resolver._latestVersion[uv.name]) -
semverToNum(uv.version);
if (isRootDep[uv.name]) {
// root dependency
// preferably latest
cost[MAJOR] += latestDistance;
} else {
// transitive dependency
// prefarable earliest possible to be conservative
// xcxc XXX but for now prefering the latest is OK too
cost[MINOR] += latestDistance;
}
}
var latestDistance =
semverToNum(self.resolver._latestVersion[uv.name]) -
semverToNum(uv.version);
cost[MAJOR] += latestDistance;
});
return cost;
@@ -255,10 +269,19 @@ ConstraintSolver.PackagesResolver.prototype._getResolverOptions =
resolverOptions.estimateCostFunction = function (state, options) {
// xcxc fill me in with something smart
return [0, 0, 0, 0];
};
resolverOptions.combineCostFunction = function (costA, costB) {
// xcxc fill me in with something smart
if (costA.length !== costB.length)
throw new Error("Different cost types");
var arr = [];
_.each(costA, function (l, i) {
arr.push(l + costB[i]);
});
return arr;
};
break;