github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Check for invalid package names early in the codepath.

Browse Source 
We already don't work with packages that contain '.' in the name, this just moves the error up and makes it clearer.
This commit is contained in:
Nick Martin
2013-08-06 15:23:57 -07:00
parent dfd2068d4f
commit e7bb166a02
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/library.js
View File

@@ -175,6 +175,17 @@ _.extend(Library.prototype, {
return self.loadedPackages[name].pkg;
}
// Check for invalid package names.
//
// XXX should we be even stricter and whitelist something like
// /\-_A-Za-z0-9/ instead of blacklisting some special characters?
// What about unicode package names?
if (/[\.\?|'"#<>\(\)]/.test(name)) {
if (throwOnError === false)
return null;
throw new Error("Invalid package name: " + name);
}
var packageDir = self.findPackageDirectory(name);
if (! packageDir) {