github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid calling files.stat(source) in symlinkWithOverwrite.

Browse Source 
This was dangerous because source is often a path relative to the old
target file, whereas files.stat was interpreting source as a path relative
to process.cwd().

Fixes #9203.
This commit is contained in:
Ben Newman
2017-10-16 14:07:11 -04:00
parent 86ec7eb5db
commit eded323039
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tools/isobuild/builder.js
View File

@@ -729,23 +729,19 @@ function atomicallyRewriteFile(path, data, options) {
// create a symlink, overwriting the target link, file, or directory
// if it exists
function symlinkWithOverwrite(source, target) {
const args = [source, target];
if (process.platform === "win32") {
if (! files.stat(source).isDirectory()) {
throw new Error("symlink source must be a directory: " + source);
}
args[2] = "junction";
}
try {
files.symlink(...args);
files.symlink(source, target);
} catch (e) {
if (e.code === 'EEXIST') {
if (e.code === "EEXIST") {
// overwrite existing link, file, or directory
files.rm_recursive(target);
files.symlink(...args);
files.symlink(source, target);
} else if (e.code === "EPERM" &&
process.platform === "win32") {
files.rm_recursive(target);
// This will work only if source refers to a directory, but that's a
// chance worth taking.
files.symlink(source, target, "junction");
} else {
throw e;
}