unnecessary: because dontRunConstraintSolver now means we don't need to
be in a buildmessage.capture
dangerous: because if you don't check the result of
buildmessage.capture, you leak errors.
- Errors in merging the cordova branch against 273b70bea4 left
in an unnecessary getLocalPackages function
- LocalCatalog.getLocalPackageNames is unnecessary (it's the same as
getAllPackageNames!) CompleteCatalog.getLocalPackageNames is OK I
guess.
- getPackagesForTest returned some extra data that was only used to call
the nonexistent catalog.removeLocalPackage method. Meh, we don't
clean up the catalog when the command ends now (which doesn't happens
unless you're using --once anyway). We'll probably fix this by making
catalog.complete less global soon anyway (ie, it should be build-specific).
- Fix a duplicate test runner app cp_r
Bug introduced in 0.9.4. This only seems to occur in some contexts; a
way to consistently reproduce is:
$ rm -rf packages/test-in-browser/.build.test-in-browser && curmeteor test-packages
[[[[[ Tests ]]]]]
=> Started proxy.
=> Started MongoDB.
=> Errors prevented startup:
While Building package `test-in-browser`:
error: package not available: bootstrap
- Simplify internal data structure to just have one map of name ->
various data instead of a whole bunch of different unsynchronized data
structures (most of which were used with frequent O(n) operations).
- Move the getLoadPathForPackage logic which combines local and remote
packages into LayeredCatalog from LocalCatalog, and delete the
unnecessary copy in BootstrapCatalogCheckout.
- Rename a bunch of fields to make it explicit which ones contain
package objects, which ones contain package directories, and which
ones contain package *search* directories
- Replace random version IDs and a long comment about why random is safe
with sequential. (I don't think these version IDs are ever used
anyway.)
- Drop unused "initializing" option to refresh
- Drop redundant call to _recomputeEffectiveLocalPackages in
addLocalPackage (it is called immediately below by refresh).
It should only need a capture if you need to include
buildinfo. Specifically, the use in tropohouse for package merging
should not be able to fail with a buildmessage.
Failures to statically compile packages for the tool now just crash the
tool, just like uniload failures. This should never happen unless you're
working from a checkout and have broken a core package.
They are unused (and were accidentally introduced in 0.9.4 with the
sqlite branch). The only thing you're allowed to query for releases is
the official catalog, since the complete catalog doesn't actually
augment releases with anything.
(If we later implement some sort of "local release", we should probably
also introduce a new release-specific interface that can be backed
either by sqlite or by sqlite-plus-local, analogous to catalog. There's
no real reason that it should be the same interface as catalog.)
Change this to "Checking local packages versions" to more accurately
reflect what we're doing.
Also add a few more debug statements so it is clearer when we are and aren't
downloading new versions.
Closes#2950
