- Line 497: `return` after `throw`
- Lines 523 - 527: `e` already defined in same function scope
(hoisting)
- Line 937: Missed semicolon
- Line 1095: Very confused about ES6 “default parameter” set via
colon, which probably will be interpreted as Object - Babel failed to
build on my end, regarding [this
docs](https://mongodb.github.io/node-mongodb-native/api-generated/cursor
.html#count) it should be a Boolean, so we set it to `false` by default
- Line 1120: no need to set variable to `undefined`
- Lines 1122, 1128, and 1133: Define `doc` above while due to function
scope and hoisting `doc` is already allocated inside `while` and `try`
Tiny fix for an old issue where the console output would get corrupted when running `meteor admin set-unmigrated` or `meteor admin change-homepage` due to missing newline on `rawInfo` command.
Fixesmeteor/meteor#4054
This fixes a regression caused by 88d43a0f16 which is demonstrated in meteor/meteor#7849.
Essentially, with the current implementation some Cordova build elements are "stale" when the build is copied. For example, if you execute a `meteor run ios` and then `meteor build . --server=http://example.com/` (note: `example.com`) the `config.xml` (`<access origin />`), the boilerplate HTML (`__meteor_runtime_config__`) and other elements of the bundle (`Info.plist` on iOS) will still contain the previously used `http://<local_ip>:3000` address instead of `http://example.com` as they should.
Additionally, it would appear that it's impossible to actually checkout a project and immediately run `meteor build` without running `meteor run (android|ios)` first.
Various work-arounds for this seem to exist, such as running `meteor build` twice, or running `meteor run --server=http://production.com` first.
Ultimately, this is occurring because the bundle is being copied before the Cordova `prepareForPlatform` occurs which I believe was not intended.
There is already a test in place which fails without this fix, but marked as `slow` and therefore not executed on CircleCI. Specifically, `cordova builds with server options` would have caught this. Forcibly running this test locally now passes with this change.
Fixesmeteor/meteor#7849Fixesmeteor/meteor#7291Fixesmeteor/meteor#6756
Previously, the width (or "columns") for the readline shell was being obtained on the server. This causes problems for clients which are connecting to the server which are sized differently.
The client will still have problems if they resize AFTER they are connected to the REPL, but at least they have the option of being a different size.
A more complete solution would be to have the client listen on process.stdout "resize" and pass that to the server when it occurs, but I'm not sure of an easy way to do that with the current communication (perhaps pause-reconfigure-unpause?).
Fixesmeteor/meteor#5346
The value passed into from `Meteor.clearTimeout` or `Meteor.clearInterval` is an opaque handle returned by `Meteor.setTimeout` and `Meteor.setInterval` accordingly.
That is to say, on some engines it will be a `Number` and on others an `Object` but you need not worry about the actual type.
Closesmeteor/meteor#7778
Removing thest tests which aren't defined anywhere anymore but the exceptions to skip them are still in place:
* ^mongo - logged (in|out)
* ^logs - logged (in|out)
* ^can't publish package with colons
Since multiple self-tests could run in a series now, this makes sure that when any of them fails, the error is propagated to CircleCI but still lets them all finish.
This reverts commit 7df3ccaa2195af2628f20752104b331997137b73 which introduced a change which required `bash`.
I don't want to force `bash` for a test runner.
This might be overboard as it adds some additional code but the regex off the screen was midly unpleasant.
One additional benefit to this is that you could have a list of excluded tests stored in a separate file and use:
```
ADDL_SELF_TEST_EXCLUDE="$(cat addl_tests.txt)"
```
(note the importance of double quotes to preserve newlines)
This permits changing TIMEOUT_SCALE_FACTOR using a variable instead of hard-coding it in the script.
Also adds ADDL_SELF_TEST_EXCLUDE to define environment specific tests which must be skipped.
For example, I run my preliminary (personal) Meteor tests on SemaphoreCI, but there is a particular test that just _will not work_. This allows me to override particulary problematic tests without sed-ing the script.
This changes the CI script to make sure it runs all tests, regardless of the environment configuration while still allowing flexibility in the size of the container parallelism.
While not having any effect on the Meteor configuration this will now run all 8 test groups across a fewer number of containers, if necessary.
This fixes issues where false-positives are achieved on contributor PRs, like seen on meteor/meteor#7963. I explained here:
https://github.com/meteor/meteor/pull/7963#issuecomment-264188162
This change will also allow the script to run tests in their entirety if the parallelism configuration is missing, such as when run from a local dev box.
