Several years ago, before all major browsers supported source maps, we
felt it was important to provide line number information in generated
files using end-of-line comments like "// 123\n".
Adding all these comments was always slower than leaving the code
unmodified, and recently they have begun interacting badly with certain
newer ECMAScript syntax, such as multi-line template strings (#9160).
Since source maps are well supported in most browsers that developers are
likely to be using for development, and the line number comments are now
causing substantive problems beyond the performance cost, I think it's
time we stopped using them once and for all.
Fixes#9160.
* Add test for sorting with falsey selector
Falsy selectors should result in empty result and sorting shouldn't blow up.
* Protect sorter from falsey selectors
* Handle overridden _.template settings in boilerplate-generator
When `underscore`'s default `_.template` settings are overridden
using `_.templateSettings` in an application, this can adversely
affect the `_.template` calls used by the `boilerplate-generator`
to render an application's initial HTML template. These changes
make sure the `boilerplate-generator` is overridding any
defined `_.templateSettings` with its own verified to work
settings.
Fixes#9149.
* Add comment explaining additional _.template config override
* Handle overridden _.templateSettings with the cordova boilerplate
* Remove underscore use wherever possible
* Change incorrect implementation of an "empty" manifest.
This test was trying to imply an empty manifest by using an empty
associative array (hash), whereas a manifest is only ever an array
of hashes (as per the bundler code). Therefore, an empty manifest
should be an array with no items.
This is to fix the failure seen in https://travis-ci.org/meteor/meteor/builds/291857783?utm_source=github_status&utm_medium=notification
because of @hwillson's changes in 9aee811a4b.
Refs: meteor/meteor#9250.
* Make underscore replacement code more defensive
`_.map` handles a falsy input value, whereas `Array.prototype.map`
(obivously) does not. While not likely common practice, it's
possible falsy values are being passed into the boilerplate
generator, for elements like `js`, `css`, etc. These changes
replicate `_.map`'s handling of incoming falsy values by
converting them to an empty array.
* Update Facebook OAuth app config steps
Facebook has updated their application developer portal, so the
steps for creating a Facebook OAuth app have changed. This commit
updates the steps shown as part of the `facebook-config-ui`
setup process, to line up with Facebook's new dev portal.
Fixes#8867.
* Capitalize CAPTCHA.
Nit: Capitalized CAPTCHA since it's an acronym.
* Bump facebook-config-ui package version to 1.0.1.
The `installPath` property was always essentially an absolute module
identifier that was simply missing the leading '/' character, so this
commit acknowledges that role by renaming the property to `absModuleId`
and adding the leading slash.
The react-dom@16 npm package recently got stricter about how it checks
that dead code elimination is enabled. Specifically, it no longer just
checks that process.env.NODE_ENV is replaced with "production" but also
requires conditional branches to be completely removed if the replacement
makes them unreachable:
https://github.com/facebook/react/blob/master/packages/react-dom/npm/index.js
The minifier-js package recently had its minor version bumped for Meteor
1.6, so I think it's safe to enable dead code elimination in a patch
version update. If we bumped the minor version again (to 2.3.0), this
version of minifier-js would not be usable with Meteor 1.6, and would
probably have to wait for Meteor 1.6.1.
Bumping the patch version of standard-minifier-js is also necessary
because it uses minifier-js as a compiler plugin, and would otherwise
continue to bundle the old minifier-js plugin.
