Commit Graph

17590 Commits

Author SHA1 Message Date
Ben Newman
c829bf580e Merge pull request #7840 from meteor/reconfigure-mongo-when-port-differs
Reconfigure Mongo replica set when --port differs
2016-09-29 16:56:36 -04:00
Ben Newman
dd3fe9a264 Add additional delay to "run: run" test. 2016-09-29 16:03:18 -04:00
Michiel ter Reehorst
8dbfd9769a Bump the coffeescript package version (#7845)
That way everyone who wants to can update to version `1.2.6` and enjoy coffeescript `1.11.0`.
2016-09-29 15:59:35 -04:00
Lieuwe Rooijakkers
c13fe33aa3 coffeescript: improve es6 regex performance (#7846) 2016-09-29 15:59:06 -04:00
Ben Newman
295d3d5678 Kill mongo when server process exits.
We try to kill any mongod processes before starting new ones, but this
change kills it when the development server shuts down, too.

Killing mongo on shutdown is particularly important for tests that run
meteor multiple times in a row, and for whatever reason fail to find and
kill running mongod processes on startup, e.g. because the --port has
changed (#7563).

This comment by @glasser seems to suggest this is a reasonable idea:
https://github.com/meteor/meteor/issues/2182#issuecomment-45685614

Fixes #2182 and possibly other related bugs.
2016-09-29 09:48:55 -04:00
Ben Newman
5b2e08a80c Automatically reconfigure Mongo replication set when --port differs.
Fixes #7563.
2016-09-29 09:48:55 -04:00
Ben Newman
20a6604126 Remove pointless and exception-swallowing assert.doesNotThrow wrappers. 2016-09-29 08:51:57 -04:00
Ben Newman
f8ba1226b1 Rename test entry point module so that it isn't ignored. 2016-09-29 08:51:56 -04:00
Ben Newman
697e7ae0f7 Protect against null return values from getDevBundleForRelease. (#7841)
Fixes #7838.
2016-09-28 19:54:10 -04:00
lucfranken
e06da93fd8 Fix #7827 - Fix link in Contributing.md (#7834)
Link to Meteor website was broken and there were 2 links which looked
like one. Replaced with a link to the list of packages in the Meteor
repository to give the best currently available overview of the parts
of Meteor.
2016-09-28 09:41:32 -04:00
Geoffrey Booth
12472cfe7a CoffeeScript now supports ES2015 modules (#7818)
* Update CoffeeScript to 1.11.0, which supports modules; update check for whether to pass CoffeeScript’s output to Babel to look not just for backticks, but also for `import`, `export` and `function*`, the current ESNext features output by CoffeeScript

* Add tests for imported modules using CoffeeScript’s new native import statement

* Test that CoffeeScript native export statements work, by importing something exported by such a statement

* Improve regex

* Optimize regex
2016-09-28 09:36:53 -04:00
Mehdi Ahraoui
2bc5b4b3b6 Meteor should check if is running as root and prevent it on Unix (#7821)
* Prevent running sudo meteor run it on Unix

Prevent running sudo meteor run it on Unix

Fix for all commands

remove empty line

Revert "Prevent running sudo meteor run it on Unix"

This reverts commit d2867561bb6fb1b259a59556628b56a64c677a0b.

improve PR

improve PR

improve PR

fix PR

* improve PR

* fix PR

* fix PR

* fix PR
2016-09-28 09:34:53 -04:00
Seba Kerckhof
8cdab91bc4 Do not check connection with protected npm registries (#7637)
* Do not check connection with protected npm registries

* Remove need for registry http get check by tuning npm retry parameters
2016-09-28 09:29:35 -04:00
Jesse Rosenberger
465a7f724c Merge pull request #7819 from alphanso/iss7478
Use -s as short form of --settings flag
2016-09-28 03:46:37 +03:00
Jesse Rosenberger
d787654e60 Update help.txt with -s shorthand for --settings flags.
The -s flag is now shorthand for --settings

Related to meteor/meteor#7478
2016-09-28 02:52:11 +03:00
Zoltan Olah
e78e27dd3a Merge pull request #7800 from abernix/abernix-fix-7538
[docs] Clarify JSDoc for pollingIntervalMs and pollingThrottleMs options
2016-09-27 15:55:30 -07:00
Zoltan Olah
6d36f47cef Merge pull request #7801 from abernix/abernix-fix-issue-7786
Add Newlines to end of .gitignore files, specifically the new app skel
2016-09-27 15:53:54 -07:00
Jesse Rosenberger
cba649f709 Add Newlines to end of .gitignore files, specifically the new app skel
Even though I think the fight is a bit futile, it is considered best practice to have newlines at the end of all files.  At the request of meteor/meteor#7786, this commit adds newlines to the end of the new app skeleton `.gitignore` file.  These skel files are used when generating new meteor apps so this avoids perpetuation of this problem into futrue generations. ;)

In an effort to beef up this PR, I also took the liberty of fixing the few other Meteor files which were lacking newlines (all `.gitignore` files)

Closes meteor/meteor#7786
2016-09-26 15:32:08 +03:00
Rishabh Singhal
ec644b729a Use -s as short form of --settings flag 2016-09-25 13:56:58 +05:30
Jesse Rosenberger
4c2ba4ff4b Await Promise when running npm install (#7805)
I believe this is the fix for the (recent) CI server timeouts.
2016-09-23 11:20:33 -04:00
Ben Newman
d5f6350fd4 Merge branch 'release-1.4.2' into devel
New policy: pull requests for Meteor releases (e.g. release-1.4.2) will
now target the master branch instead of devel, and we will merge the
release branch back into devel periodically (say, every time we release a
new beta or release candidate).

All other pull requests should continue to target devel.
2016-09-22 15:52:41 -04:00
Ben Newman
d4d648c8f7 Bump package versions for 1.4.2-beta.5 release. release/METEOR@1.4.2-beta.5 2016-09-22 15:03:07 -04:00
Ben Newman
aa6b8ff10a Cleanup packages/stylus/.npm after upgrade.
This may help with the CircleCI timeout problems we've been having.
2016-09-22 15:03:07 -04:00
Ben Newman
9810562403 Test that one package can have both node_modules and Npm.depends. 2016-09-22 14:34:32 -04:00
Ben Newman
da5f6956aa Merge branch 'devel' into release-1.4.2 2016-09-22 14:32:07 -04:00
Ben Newman
03c5346873 Stop building meteorInstall bundle for server node_modules.
This saves a potentially large amount of work by the ImportScanner and the
Resolver during makeServerTarget, because it means we no longer have to
scan and resolve modules to build a server bundle as a backup for native
Node evaluation.

I've attempted this optimization before, but it wasn't really safe until
I fixed some obscure bugs that caused module.useNode() to fail during
`meteor test-packages` (see recent local-test:-related commits).
2016-09-22 14:27:32 -04:00
Ben Newman
726074689e Don't prepend node_modules/meteor/<package>/ for npm/... directories. 2016-09-22 14:27:31 -04:00
Ben Newman
bbac272530 Prefer node_modules directories from non-test packages. 2016-09-22 14:27:31 -04:00
Ben Newman
7401bad8e3 Tolerate multiple node_modules directories per package.
Revert "Write node_modules metadata as single strings."
This reverts commit f74975d0df.

Packages published with multiple node_modules directories won't be
loadable by versions of Meteor before 1.3, because older versions of
Meteor don't understand object-valued isopack "node_modules" fields, but
the vast majority of Meteor developers are now using either 1.3 or 1.4.
2016-09-22 13:06:03 -04:00
Tom Coleman
942221d07f Merge pull request #7799 from abernix/fix-issue-7445-2
Add support for `--no-release-check` to `meteor test` command
2016-09-22 15:54:02 +10:00
Tom Coleman
5f81996cdb Don't show a spinner while getting ready 2016-09-22 11:50:44 +10:00
Tom Coleman
f5bc7ae0ce Shrinkwraps and .versions files for npm-mongo and stylus 2016-09-22 11:24:48 +10:00
Tom Coleman
b8d3fb03ca This is better 2016-09-22 11:24:13 +10:00
Tom Coleman
25c03ce9ab Add a timeout to the get ready step 2016-09-22 11:19:39 +10:00
Ben Newman
3313180a6f Always use dev_bundle/.npm as the cache for meteor npm ... commands.
I believe a strange interaction with the global cache (~/.npm on Unix
systems) may have been the root cause of the problem fixed by this commit:
https://github.com/meteor/meteor/pull/7668/commits/ad61a935146c34e7
2016-09-21 18:53:33 -04:00
Jesse Rosenberger
ae006ca0b5 Clarify documentation for pollingIntervalMs and pollingThrottleMs options
This change changes units to be consistent and more clearly indicates when these parameters come into play.

Fixes meteor/meteor#7538
2016-09-21 17:20:21 +03:00
Jesse Rosenberger
7097f78926 Add support for --no-release-check to meteor test command
This functionality for the `test` command was overlooked when meteor/meteor#7445 was implemented.

Closes meteor/meteor#7026
2016-09-21 15:59:47 +03:00
Brian Lukoff
a3419f8ccf Update node-mongodb driver to 2.2.10 (#7780)
This release of the node-mongodb driver finally fixed performance issues we were having on our Compose MongoDB 3.2 deployment.
2016-09-20 18:31:55 -04:00
Tom Coleman
78b9a20da1 Merge pull request #7739 from meteor/stylus-version-bump
Updating stylus dependency
2016-09-20 09:05:39 +10:00
Ben Newman
d881a29de4 Bump package versions for 1.4.2-beta.4 release. release/METEOR@1.4.2-beta.4 2016-09-16 09:15:24 -04:00
Ben Newman
62b85ee36e Merge branch 'devel' into release-1.4.2 2016-09-16 09:10:33 -04:00
Ben Newman
6823ea0bca Bump boilerplate-generator package version and add version constraints.
This will allow publishing `boilerplate-generator` independently from
Meteor, so that Meteor 1.4 developers can update immediately by running
`meteor update boilerplate-generator`.
2016-09-16 09:07:25 -04:00
gsaynac
f475e379ab Add ws: and wss: sources to default CSP for Cordova (#7774)
CircleCI tests are still timing out, but I believe this change is safe to merge.
2016-09-16 09:01:44 -04:00
Ben Newman
1b25050aa8 Delay disposing of file watchers, in case acquireWatcher called again.
Typically all outstanding watchers will be closed when the development
server restarts, but we can save a lot of effort if they survive the
restart, for the small cost of keeping them open for an extra 30sec.
2016-09-15 19:44:00 -04:00
Ben Newman
d5f239e455 Use global file watching oracle to compute file hashes cheaply.
For the galaxy-server application, this reduces the time spent in
watch.isUpToDate from six seconds to a little over second. Of course we
should also try to call it less often, but making it cheaper helps!
2016-09-15 19:42:55 -04:00
Ben Newman
219b18168d Establish a global source of truth for file watching events.
This should not only reduce the total resource usage of the file watching
system, but pave the way for a faster implementation of watch.isUpToDate.
2016-09-15 19:34:57 -04:00
Ben Newman
d618cc61a3 Optimize meteorNpm.getProdPackageNames by not calling runNpmCommand.
For the galaxy-server application, this reduces the time taken to
determine production node_modules from 1400ms to 120ms.

As another optimization, we could record the hashes of all the
package.json files encountered in this scan, and return the same set of
production package names if those hashes have not changed, though the
benefits may not be worth the additional complexity.
2016-09-15 16:20:47 -04:00
Ben Newman
1850105f90 Refactor production node_modules filtering. 2016-09-15 16:15:04 -04:00
Ben Newman
c0e3397cc4 Merge branch 'devel' into release-1.4.2 2016-09-15 10:02:34 -04:00
Michael Mason
ffa7de2559 Pass object with error to onLoginFailure hooks (#7699)
* Pass object with error to onLoginFailure hooks

* Use es6 property shorthand
2016-09-15 10:00:28 -04:00