Commit Graph

18335 Commits

Author SHA1 Message Date
Ben Newman
2f3f90d7e6 Bump package versions for 1.4.3-rc.4 release. release/METEOR@1.4.3-rc.4 2017-02-10 12:05:17 -05:00
Ben Newman
ce547d69ef Add v1.4.3 header to History.md. 2017-02-10 11:44:33 -05:00
Hugh Willson
a0b323f3e3 Moved spiderable into non-core. 2017-02-10 11:40:29 -05:00
Ben Newman
d40c54a879 Merge pull request #8346 from meteor/abernix/polishing-accounts-7715
Touch-ups for Accounts Package Changes
2017-02-10 11:39:27 -05:00
Jesse Rosenberger
2a09a6740a Move deprecated account packages to deprecated instead of non-core.
Since they're deprecated and non-core.
2017-02-10 17:39:02 +02:00
Jesse Rosenberger
44954fee0c Use hasOwnProperty instead of checking against undefined primitive.
Gets rid of superflous parenthesis too.
2017-02-10 17:34:55 +02:00
Jesse Rosenberger
d0151c04f1 Improve the display of the deprecation warning for accounts packages 2017-02-10 17:34:55 +02:00
Jesse Rosenberger
786511dffc Move facebook out of deprecated for consistency, for now.
It will get moved back in an upcoming merge.
2017-02-10 17:34:55 +02:00
Jesse Rosenberger
2c5dda1675 Explicitly join the fields array to a comma-delimited string.
With https://github.com/meteor/meteor/pull/8261 merged, arrays are no longer concatenated (with commas) into a string during `HTTP.call` requests so we need to specify the exact behavior we want. Any previous behavior of this type was purely accidental.

The definition of this field in Facebook's API is that it should be a comma-separated field:

https://developers.facebook.com/docs/graph-api/using-graph-api
2017-02-10 17:34:54 +02:00
Jesse Rosenberger
8c7758015d Fix inaccurate comment
This should have been updated when 8de559a was changed.
2017-02-10 17:34:54 +02:00
Jesse Rosenberger
bf59881fc9 Cleanup the warning message which is displayed on server and client
This implements a more clean formatting for the message.
2017-02-10 17:34:28 +02:00
Jesse Rosenberger
f4d677fbc8 Add an upgrader which modifies accounts-* packages automatically.
The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 https://github.com/meteor/meteor/issues/7715#issuecomment-276529351

 Relates to:

  * facebook: https://github.com/meteor/meteor/pull/7728
  * github: https://github.com/meteor/meteor/pull/8303
  * google: https://github.com/meteor/meteor/pull/8275
  * meetup: https://github.com/meteor/meteor/pull/8231
  * meteor-developer: https://github.com/meteor/meteor/pull/8305
  * twitter: https://github.com/meteor/meteor/pull/8283
  * weibo: https://github.com/meteor/meteor/pull/8302
2017-02-10 17:34:28 +02:00
Hugh Willson
e6d905ca54 Adjusted query string array representation to remove indices. (#8342)
* Adjusted query string array representation to remove indices.

* Increased major version since the new _encodeParams() result is not backwards compatiable.
2017-02-10 17:34:27 +02:00
Jesse Rosenberger
873f13d743 Upgrade Facebook Graph API to use v2.8
In testing for #7715, I discovered that the v2.2 Graph API endpoint was still in use in the `facebook` package which was due to sunset on 2017-03-25.

See Facebook Graph API Changelog here:
  https://developers.facebook.com/docs/apps/changelog

When a Graph API endpoint is sunset, it (is claimed) to automatically turn over to the next more recent version, in this case v2.3.

v2.3 has a breaking-change over v2.2, notably listed in "Changes from v2.2 to v2.3":

> [Oauth Access Token] Format - The response format of https://www.facebook.com/v2.3/oauth/access_token returned when you exchange a code for an access_token now return valid JSON instead of being URL encoded. The new format of this response is {"access_token": {TOKEN}, "token_type":{TYPE}, "expires_in":{TIME}}. We made this update to be compliant with section 5.1 of RFC 6749.

This change updates both Graph APIs to v2.8 which has LTS until "At least October 2018".
2017-02-10 17:34:27 +02:00
Ben Newman
12f35950c1 Improve formatting of accounts reorganization History.md entry
Also fixed the pull request number for the `meetup` package.
2017-02-09 18:33:02 -05:00
Ben Newman
81cc8aabcf Bump package versions for 1.4.3-rc.3 release. release/METEOR@1.4.3-rc.3 2017-02-09 16:40:35 -05:00
Ben Newman
bcffe53d14 Consider npm packages with {,pre,post}install scripts non-portable.
Inspired by analysis from @danstiner:
https://github.com/meteor/meteor/issues/8225#issuecomment-275044900

Fixes #8225, as well as the tests I added in 672c4f338a.

I changed the name of the .meteor-portable file to .meteor-portable-1.json
in order to invalidate previous .meteor-portable files. This naming scheme
will be more sustainable, because we can keep incrementing the version
number whenever we change this logic.
2017-02-09 16:04:23 -05:00
Ben Newman
672c4f338a Add the modules test app to the self-test suite.
I've been running these tests manually ever since Meteor 1.3, but they
really should run every time.
2017-02-09 12:09:48 -05:00
Ben Newman
fabad4cc8d Overwrite implicit modules only if they are package.json files.
Implicit empty stub CSS modules added in addStylesheet in
compiler-plugin.js were being overwritten with actual CSS module code,
thanks to logic intended to support replacing package.json stubs with
their actual contents.

The meaning of "implicit" is somewhat overloaded: for package.json
modules, it means the module is a minimal stub (just the "name",
"version", and "main"/"browser" fields) that should be replaced if ever
explicitly imported. For empty stub CSS modules, it means the module
should yield to any actual modules added via addJavaScript.
2017-02-09 12:09:34 -05:00
Ben Newman
365ceb6386 Tolerate ENOENT exceptions from files.realpath in isWithinProdPackage. 2017-02-08 17:18:30 -05:00
Ben Newman
e2cf76f8da Move deprecated packages from packages/non-core to packages/deprecated.
These subdirectories are functionally equivalent, but obviously the
packages/deprecated directory is a better home for deprecated packages.
2017-02-08 16:20:23 -05:00
Ben Newman
19a2606539 Merge branch 'devel' into release-1.4.3 2017-02-08 16:02:53 -05:00
Ben Newman
6a4d76ef8e Remove -beta.n suffix from less before republishing. 2017-02-08 15:55:28 -05:00
Ben Newman
6b6e5d8017 Remove -beta.n suffix from minifier-css before republishing. 2017-02-08 15:46:27 -05:00
Ben Newman
7e13201f12 Remove -beta.n suffix from minifier-js before republishing. 2017-02-08 15:45:56 -05:00
Ben Newman
3163085e1f Remove -beta.n suffix from standard-minifier-js before republishing. 2017-02-08 15:41:57 -05:00
Ben Newman
af100fdb60 Remove -beta.n suffix from standard-minifier-css before republishing. 2017-02-08 15:41:04 -05:00
Ben Newman
3868e83dee Remove -beta.n suffix from stylus package before republishing. 2017-02-08 15:38:28 -05:00
Ben Newman
3761fd4bf1 Bump package versions for 1.4.3-rc.2 release. release/METEOR@1.4.3-rc.2 2017-02-08 15:10:39 -05:00
Ben Newman
0e0ad9f629 Move deprecated packages into packages/non-core. 2017-02-08 15:09:55 -05:00
Ben Newman
2010e9d11a Merge branch 'devel' into release-1.4.3 2017-02-08 14:47:03 -05:00
Ben Newman
858dc64db4 Merge branch 'master' into devel 2017-02-08 14:43:26 -05:00
Ben Newman
fde9e0bbbd Merge pull request #8330 from meteor/release-1.4.2.6
Release 1.4.2.6
2017-02-08 14:41:09 -05:00
Ben Newman
351e05ddf4 Bump package versions for the official 1.4.2.6 release. release/METEOR@1.4.2.6 2017-02-08 13:25:04 -05:00
Ben Newman
f919dab834 Update History.md to reflect changes in 1.4.2.6. 2017-02-08 13:23:40 -05:00
Blake Bourque
6df240e65b Fix for 8309 (#8331)
Strip the trailing /
2017-02-08 10:18:58 -08:00
Ben Newman
a301184a3f Bump package versions for 1.4.2.6-rc.0 release. release/METEOR@1.4.2.6-rc.0 2017-02-08 12:04:06 -05:00
Hugh Willson
21957e03c7 Added release dates beside release version numbers (to address #8193). (#8316) 2017-02-08 11:35:51 -05:00
Jesse Rosenberger
d62d935c77 Add other account package changes to History.md
Including:
 * `github`: https://github.com/meteor/meteor/pull/8303
 * `meteor-developer`: https://github.com/meteor/meteor/pull/8305
 * `meetup`: https://github.com/meteor/meteor/pull/8231
 * `weibo`: https://github.com/meteor/meteor/pull/8302
2017-02-08 11:30:55 -05:00
laosb
3dcba0d466 Accounts splitting History.md update. 2017-02-08 11:30:55 -05:00
Ben Newman
bdc987217c Merge pull request #8302 from meteor/accounts-weibo-reorg
Accounts-weibo reorganize
2017-02-08 11:29:09 -05:00
Ben Newman
1c0060f160 Merge pull request #8303 from hwillson/issue-7715
Wired up new github accounts changes to separate the UI from oauth calls
2017-02-08 11:27:27 -05:00
Ben Newman
6eafbee380 Merge pull request #8305 from hwillson/issue-7715-meteor-developer
Wired up new meteor-developer accounts changes to separate the UI from oauth calls
2017-02-08 11:17:21 -05:00
Ben Newman
2f0371afa1 Merge pull request #8321 from hwillson/issue-7715-meetup
Wired up new meetup accounts changes to separate the UI from oauth calls
2017-02-08 11:15:22 -05:00
Hugh Willson
c7e8706100 Adjusted the url package to encode nested objects and arrays (to help address #5065). (#8261)
* Adjusted the url package common code to encode nested objects and arrays properly (to help address #5065).

* Adjusted to make sure a 'hasOwnProperty' param name is handled.
2017-02-08 11:09:15 -05:00
Ben Newman
cafe4cc084 Fix bad npm package stripping logic introduced to fix #8136.
When `start + maxPartCount > parts.length`, this code was comparing
array holes to strings, leading to unpredictable results.

Blame: 2613582311
2017-02-08 11:04:20 -05:00
Jesse Rosenberger
63b8fba326 Change twitter-oauth => to weibo-oauth
Seemingly copy-paste residue in the PR, but this is the Weibo package
it should be Weibo, not Twitter.
2017-02-08 14:29:04 +02:00
Ben Newman
ff4b00c774 Mention release-based core package version constraints in History.md. 2017-02-07 17:55:31 -05:00
Ben Newman
33e4a6e658 Bump package versions for 1.4.3-rc.1 release. release/METEOR@1.4.3-rc.1 2017-02-07 15:36:12 -05:00
Ben Newman
868a52829f Register package@version constraints for current release.
Package version unpinning (#7084) removed all exact package@=version
constraints derived from the current release.

As we discovered with Meteor 1.4.2.4 (#8306), this meant releases no
longer had any power to enforce package upgrades, which is why the
follow-up Meteor 1.4.2.5 release (#8311) was necessary.

This commit has the same effect as putting package@version in your
.meteor/packages file for every local/core package that your app uses.
2017-02-07 14:52:49 -05:00