Commit Graph

18589 Commits

Author SHA1 Message Date
Ben Newman
f3c2eaf5bf Bump package versions for 1.4.4-rc.6 release. release/METEOR@1.4.4-rc.6 2017-04-03 20:24:06 -04:00
Ben Newman
87d0a33067 Get Cordova plugin test to pass by adding time. 2017-04-03 18:43:54 -04:00
Ben Newman
954efa7f5a Support Google Sign-In in google-oauth package. (#8549)
* Support Google Sign-In in google-oauth package.

Addresses #8253.

* Use Meteor.startup instead of listening for deviceready event.

* Fix mobile-config.js typo.

* Bump accounts-google and google-oauth package versions.

I'm only bumping the patch versions, even though the recent changes to
these packages may seem significant, for two reasons:

1. Bumping the minor versions would force Meteor 1.4.3 developers to
   upgrade to Meteor 1.4.4 if they wanted to use these changes.

2. The accounts-google and google-oauth packages without these changes
   will stop working completely in two weeks, which is much worse than the
   risks of upgrading.
2017-04-03 17:07:55 -04:00
Ben Newman
0a73a80b4b Upgrade uglify-js in an attempt to fix #8536. 2017-04-03 16:54:20 -04:00
Jesse Rosenberger
ef265077a9 Merge branch 'abernix/fix-windows-dev-bundle-extract-error' into release-1.4.3.x release/METEOR@1.4.4-rc.5 2017-03-30 20:16:24 +03:00
Jesse Rosenberger
ab111e7800 Detect dev_bundle download errors and fail appropriately on Windows.
This is in an attempt to resolve a situation which could occur when the
extraction of the dev_bundle.tar fails with an EOF error, but the tool
continues as if the file was fine.  Ultimately the, error preference
set in the PS1 script is only observed in the case of PowerShell
ErrorLevel and not just an error condition encountered in a command.
2017-03-30 16:12:19 +03:00
Jesse Rosenberger
2fd61b83a7 Bump package versions for 1.4.4-rc.5 release. 2017-03-30 15:47:07 +03:00
Jesse Rosenberger
e3d9bac133 Add -rc.n suffix to rate-limit. release/METEOR@1.4.4-rc.4 2017-03-30 03:14:45 +03:00
Jesse Rosenberger
de11f73477 Add -rc.n suffix to modules-runtime. 2017-03-30 02:17:18 +03:00
Jesse Rosenberger
276f828359 Bump package versions for 1.4.4-rc.4 release. 2017-03-30 02:16:40 +03:00
Jesse Rosenberger
d24cd94f20 Merge branch 'release-1.4.3.x' of https://github.com/meteor/meteor into release-1.4.3.x 2017-03-30 02:15:20 +03:00
Ben Newman
fcbd398ab7 Appending module identifier extensions should not match directories.
This logic needed to change not only in meteor/tools/isobuild/resolver.js
but also in the runtime module system:
cfcc422725

Fixes #8539.
2017-03-29 18:50:41 -04:00
Jesse Rosenberger
3257bafc84 Change wrapFsFunc for "move" to acknowledge _both_ arguments as paths.
The `wrapFsFunc` function accepts an array of indexes indicating which
arguments are paths.  This is particularly important on Windows, due to
the path-conversation which takes place on those strings.

The docs say:
> Indices of arguments that have paths, these arguments will be
> converted to the correct OS slashes

This follows up on the change made from meteor/meteor#8491 which failed
in our release pipeline when publishing for the Windows architecture
for `1.4.4-rc.3`.
2017-03-30 01:46:42 +03:00
Jesse Rosenberger
6d2b7c8070 Merge pull request #8520 from dhrubins/accounts-password-ambiguous-errors
Add ambiguous error messages option to Accounts config
2017-03-29 23:54:52 +03:00
Jesse Rosenberger
3a9bd40c81 Merge pull request #8520 from dhrubins/accounts-password-ambiguous-errors
Add ambiguous error messages option to Accounts config
2017-03-29 23:49:49 +03:00
Jesse Rosenberger
08d6d9f722 Add 1.4.4 -rc.n suffixes on accounts-base/accounts-server versions. 2017-03-29 23:17:37 +03:00
Jesse Rosenberger
fdef0dd972 Fixed trailing whitespace introduced into accounts-*.
Follows-up on 3c011c9dc.
2017-03-29 23:17:24 +03:00
Gabriel Engel
6f25191d03 Remove ES6 from ddp-client (#8516)
Follow-up to 05be2c784c which added new ES6 syntax, but failed to add `ecmascript`.

* Remove ecmascript Object function shorthand notation.
   as the `rate-limit` package doesn't currently use `ecmacsript` and using it for just this one instance of ES6 isn't worth it.
* Remove `ecmascript` from `rate-limit` as it is now unused.
* Bump `rate-limit` version in preparation for publishing.
Fixes #8515
2017-03-29 23:12:58 +03:00
Jesse Rosenberger
e30f30f04c Add TOOL_NODE_FLAGS support for Windows in the same way as Unix. (#8517)
In Unix we support adding `TOOL_NODE_FLAGS` when debugging the Meteor
tool itself, however Windows did not currently support it.  This should
add that support.  As this is a .bat file, I have every reason to
believe that this syntax should work on older versions of Windows as the
syntax of .bat files hasn't changed much.

Helps with meteor/meteor#8513.
2017-03-29 23:12:50 +03:00
mutdmour
3c011c9dc6 [fix #8218] cleaning up reset tokens also cleans up enroll tokens (#8474)
* solved issue 8218 with expireresettoken removing enroll tokens

* style fix

* tests fix

* solved issue 8218 with expireresettoken removing enroll tokens

* style fix
2017-03-29 23:12:34 +03:00
Jesse Rosenberger
ac4decbdae Maintain braces on if conditionals + other style changes.
This file leaves a lot to be desired, but strong preference to not
remove existing curly-braces on if-statements.

Also removed trailing whitespaces and slight indentation changes
following the changes in meteor/meteor#8520.
2017-03-29 21:57:27 +03:00
Gabriel Engel
43a7e174d1 Remove ES6 from ddp-client (#8516)
Follow-up to 05be2c784c which added new ES6 syntax, but failed to add `ecmascript`.

* Remove ecmascript Object function shorthand notation.
   as the `rate-limit` package doesn't currently use `ecmacsript` and using it for just this one instance of ES6 isn't worth it.
* Remove `ecmascript` from `rate-limit` as it is now unused.
* Bump `rate-limit` version in preparation for publishing.
Fixes #8515
2017-03-29 18:30:11 +03:00
Jesse Rosenberger
455bf5b6e0 Add TOOL_NODE_FLAGS support for Windows in the same way as Unix. (#8517)
In Unix we support adding `TOOL_NODE_FLAGS` when debugging the Meteor
tool itself, however Windows did not currently support it.  This should
add that support.  As this is a .bat file, I have every reason to
believe that this syntax should work on older versions of Windows as the
syntax of .bat files hasn't changed much.

Helps with meteor/meteor#8513.
2017-03-29 11:25:33 -04:00
mutdmour
1f8314348c [fix #8218] cleaning up reset tokens also cleans up enroll tokens (#8474)
* solved issue 8218 with expireresettoken removing enroll tokens

* style fix

* tests fix

* solved issue 8218 with expireresettoken removing enroll tokens

* style fix
2017-03-29 18:21:14 +03:00
Jesse Rosenberger
50d10aeb36 Fix bullet-point numbering on Development.md, part 2.
Follow-up to 326d17d241
2017-03-29 01:24:43 +03:00
Jesse Rosenberger
326d17d241 Fix bullet-point numbering on Development.md.
While I'm fairly sure that `0.` bullet points were always changed to correctly-ordered lists in the past on GitHub, however this no longer seems to be the case now and the first bullet-pointed number actually matters (the subsequent points do not and can be zeroes)
2017-03-29 01:22:58 +03:00
Jesse Rosenberger
be79aa8708 Bump version for 1.4.4-rc.3 release. release/METEOR@1.4.4-rc.3 2017-03-28 17:06:29 +03:00
Jesse Rosenberger
4c26a51bd8 Bump package versions for 1.4.4-rc.3 release. 2017-03-28 16:19:18 +03:00
Jesse Rosenberger
01d7aca90a Add -rc.n suffix to webapp before republishing. 2017-03-28 16:17:22 +03:00
Jesse Rosenberger
efc61160b0 Add -rc.n suffix to email before republishing. 2017-03-28 16:11:49 +03:00
Jesse Rosenberger
d60b20015b Bump $BUNDLE_VERSION to 4.7.20 before rebuilding dev bundle.
Due to the addition of d49f3e2704.
2017-03-28 16:07:35 +03:00
Phuc Nguyen
393fe17f4b Make sure manifest.json contains AUTOUPDATE_VERSION (if specified) (#8480)
Fixes https://github.com/meteor/meteor/issues/8479
2017-03-28 15:55:19 +03:00
Erik Demaine
3966d7027f Upgrade to mailcomposer@4 and smtp-connection@2. Fix #8425 (#8495)
* Switch from mailcomposer 0.1.15 -> 4.0.1 (latest, still MIT license).
* Switch from simplesmtp (which only supports mailcomposer 0.1)
  to smtp-connection (which supports any mail composer).
* Use smtp-connection@2 (instead of latest) which shares
  nodemailer-shared codebase with mailcomposer 4.0.1.
* Add test for long header lines (the original bug being fixed here)
* Add extra test for HTML + text messages
* Document some extra options arguments supported by new mailcomposer
2017-03-28 15:54:48 +03:00
Jeremy Shimko
d49f3e2704 Use fs.move() from fs-extra to fix EXDEV cross device error in docker builds. (#8491)
Use fs.move to fix EXDEV cross device error in docker builds.

Fixes #7852.
2017-03-28 15:53:22 +03:00
Ben Newman
a780686098 Bump package versions for 1.4.4-rc.2 release.
We (@abernix and I) have decided to abandon 1.4.3.3 in favor of 1.4.4,
because the changes we wanted to include are slightly more significant
than seems appropriate for a "patch" update.
release/METEOR@1.4.4-rc.2
2017-03-27 18:26:49 -04:00
Ben Newman
0bc4e2e804 Make sure Module.prototype.import === M.p.importSync for now.
The latest version of Reify generates module.importSync calls instead of
module.import calls, but we're not using module.import for anything else
(yet), so we might as well handle older generated code gracefully.

https://github.com/benjamn/reify/pull/85
https://github.com/benjamn/reify/issues/84
2017-03-27 12:34:34 -04:00
Ben Newman
0d657ed24a Use UglifyJS when possible, but fall back to Babel.minify.
This gives us all the benefits of @sethmurphy18's great work without the
additional performance hit of using Babili for everything.

With this commit:

  % meteor create min-test
  % cd min-test
  % time meteor build ../min-build
  meteor build ../min-build  39.26s user 5.49s system 112% cpu 39.647 total

Without this commit:

  meteor build ../min-build  59.28s user 5.23s system 107% cpu 1:00.08 total

Keep in mind this is the best-case scenario for Babili (a very small app).
Larger apps take much longer for Babili to minify.

cc @abernix @glasser @sethmurphy18
2017-03-27 10:02:38 -04:00
Dan Rubins
9c688d1bc6 Consolidate error handling
Per @hwillson’s comments
2017-03-26 12:40:58 -07:00
Dan Rubins
e1099dad19 Add ambiguous error messages option to Accounts
Add boolean option 'ambiguousErrorMessages' to Accounts config that sends ambiguous error messages to the client in order to mitigate user enumeration. User enumeration still possible via inference upon registration failure, but at least we’re not being as explicit about the failures.
2017-03-25 14:39:29 -07:00
Ben Newman
10127cea1f Fix modules test app now that exports.__esModule is non-enumerable.
3973bbad7f
2017-03-25 12:00:18 -04:00
Ben Newman
0eb52a1fd8 Upgrade meteor-babel to v0.19.1 and reify to v0.6.6. 2017-03-25 11:12:52 -04:00
Ben Newman
25a89b5887 Revamp .babelrc processing.
Key changes:

  1. Custom Babel plugins from .babelrc files (or "babel" sections of
     package.json files) are now treated as plugins rather than presets.

  2. Nested presets and plugins are now resolved, whereas previously only
     the top-level "plugins" and "presets" properties were examined.
2017-03-25 10:31:40 -04:00
Ben Newman
d03b352bca Convert packages/ddp-client to use ecmascript. 2017-03-24 14:24:41 +02:00
Ben Newman
5ffccdc356 Decompose requireWithPrefix helper function. 2017-03-22 18:14:00 -04:00
Ben Newman
e8b5ae6730 Convert packages/ddp-client to use ecmascript. 2017-03-22 16:45:55 -04:00
Ben Newman
91ac26b4d7 Bump package versions for 1.4.3.3-rc.1 release. release/METEOR@1.4.3.3-rc.1 2017-03-22 16:02:53 -04:00
Jesse Rosenberger
8cc3233b19 Leave note for the next BUNDLE_VERSION bumper to avoid 4.7.19.
It's been used on `devel` via b145c7ed4e.

Normally this isn't a problem, but just to avoid issues, this reminder
should help.  Can be removed, of course.
2017-03-22 20:58:26 +02:00
Jesse Rosenberger
6b4a4ccca1 Aggressively prevent CircleCI from using the wrong cache.
https://discuss.circleci.com/t/git-submodule-url-isnt-playing-nice-with-the-cache/549/3
2017-03-22 20:35:59 +02:00
Jesse Rosenberger
6bbd432081 Be more understanding of Windows' filesystem limitations.
Presently, the renaming of directories that are in-use will fail on
Windows.  This is already compensated for when `process.platform` is
set to `win32`.  However, within BashOnWindows/WSL (Windows Subsystem
for Linux), `process.platform` is equal to `linux`, though the
underlying filesystem is still the same.

Microsoft has stated that it is unlikely that they will remove
`Microsoft` from the `os.release()` value so we check for that.
2017-03-22 20:35:43 +02:00
Jesse Rosenberger
b145c7ed4e Bump $BUNDLE_VERSION to 4.7.19 before rebuilding dev bundle. 2017-03-22 20:24:26 +02:00