* Fix documentation on MAIL_URL value
See https://github.com/meteor/meteor/issues/8804
* Fix long-lines for History.md.
This file is kept word-wrapped. :)
* Additional clarification.
E-mail protocols are far too confusing.
I will squash this commit.
* Bind environment of observeChanges callbacks
This will also bind observe callbacks
* Test bound environment in observeChanges
* Use named exception handler in bindEnvironment
If an observe/observeChanges callback throws and error this will make it a bit easier to figure out where the error came form.
* Update History.md
Being a bit more specific always helps.
This may not be a complete fix for issue #8775, but I noticed while
debugging the issue that LocalCollection._removeDollarOperators isn't
removing nested $operators (as it seems like it should be):
d6c4281eeb/packages/minimongo/minimongo.js (L790)
cc @hwillson
While this was helpful in one of the incarnations of the
bundle-visualizer during development it isn't relevant anymore since
the `.stats.json` will not be present in the bundle unless it was
created by a recent version of `standard-minifier-js` which passed
in `stats` (no older versions did this).
Removing this check will also make it possible for other minifiers to be
used with `bundle-visualizer` without them also needing to fork make
their own version.
There have been a number of commits in the history for `rimraf` which
indicate others have also been struggling with ENOTEMPTY, specifically
on Windows.
https://github.com/isaacs/rimraf/commits/master
This commit, included in 2.6.1 takes a relatively aggressive approach:
d53235de86
However, due to the way the Windows filesystem is designed, this
approach may be the only way of coping with file-handles which are
cached by the OS and not released immediately upon closing a file
(in other words, at a time that Meteor would think it'd be safe to
remove the file/directory).
Attempts to help with meteor/meteor#8485.
Witty as it may be, the contribution guidelines are already listed here (and I've cleaned them up a bit too) and I'm not sure if this terminology is encouraging anyone to contribute their (precious) time.
The root of the problem was that the es5-ext npm package contains
directories called '#', e.g.
https://github.com/medikoo/es5-ext/tree/master/array/%23
These directory names were being sanitized to '' and thus ignored when
reserving paths in the Builder, which led to reservation conflicts later.
This commit fixes the problem in three different and independently
sufficient ways:
* Use files.mkdir_p instead of files.mkdir when creating parent
directories of written files.
* Replace illegal characters in sanitized paths with '_' instead of ''.
* Allow '#' in sanitized paths (only needs to be escaped in the shell, not
actually forbidden in paths).
Since changing the default "from" address could actually be a breaking
change for some applications, bump the version to 2.0.0.
Relates to meteor/meteor#8760.
Currently, the default "from" address for `meteor-accounts` is
"no-reply@meteor.com". While this works for many users, and granted it
is a "no reply" address and there should be no expectation of the
address working, it contributes to a negative spam rating for the
"meteor.com" domain and a surplus of extra e-mail.
The correct way to set the default "from" address is by setting:
Accounts.emailTemplates.from = "Name <email@domain.com>";
As per the documentation here:
https://docs.meteor.com/api/passwords.html#Accounts-emailTemplates
By changing it to "example.com", and making a more obvious "example"
out of the name ("Accounts Example"), it should encourage users to
actually change the address to something more reasonable especially
since many e-mail providers will also reject mail coming from
"example.com", which should provide a clear warning to those who have
their e-mail misconfigured.
