Commit Graph

2838 Commits

Author SHA1 Message Date
Avital Oliver
df5dc5c5be Fix {{> foo bar=false}}.
Apparently `Boolean("false")` is true.
2013-10-22 22:11:33 -07:00
Avital Oliver
4788427f9d Fix spacebars-tests
The "inclusion args" tests broke with commit
1c37ac1a98. Within
'lookup' we were wrapping results in functions
even when they were constants. This led
`{{> foo bar}}` to not correctly pass `bar`
as data into the Template pointed to by `foo`.
2013-10-22 22:02:47 -07:00
Avital Oliver
5741186ee4 Merge branch 'devel' into shark 2013-10-10 16:37:56 -07:00
Avital Oliver
f4bf7aad80 Ease the transition from {{loginButtons}} to {{> loginButtons}} 2013-10-10 16:08:00 -07:00
David Greenspan
e10145d14c comments 2013-10-10 16:04:17 -07:00
David Greenspan
21180a20e9 only access data if needed in comp.lookup 2013-10-10 15:32:58 -07:00
Avital Oliver
05985f50c1 backcompat for Handlebars.SafeString 2013-10-10 15:20:10 -07:00
Avital Oliver
df657e0af6 Deprecate preserve-inputs 2013-10-10 15:20:09 -07:00
Avital Oliver
64c2e86b2c rename variables
now when looking at a stack trace you explicitly see
`cursor.observe`
2013-10-10 15:20:09 -07:00
David Greenspan
1c37ac1a98 fix over-rendering by isolating comp.lookup
comp.lookup was establishing immediate dependencies, which was incorrect
2013-10-10 14:54:12 -07:00
Nick Martin
687f989f18 Merge branch 'master' into devel 2013-10-10 13:25:50 -07:00
David Greenspan
e350782fce wrap event handling in Deps.nonreactive 2013-10-09 17:20:18 -07:00
Emily Stark
de05d27cf3 Make browser-policy-content tell webapp about inline script policy.
This avoids the need for webapp to probe for browser-policy without
weak-depending on it.
2013-10-09 12:00:23 -07:00
Emily Stark
35cee2d4ea Test that logoutOtherClients returns a new valid token. 2013-10-08 22:01:40 -07:00
Emily Stark
cd0b6eb22f Use pollUntil in waitForLoggedOutStep 2013-10-08 22:01:40 -07:00
Emily Stark
abd9669099 Minor password test changes 2013-10-08 22:01:40 -07:00
Emily Stark
b44f0a61df Test for invalidated token after expireTokens. 2013-10-08 22:01:40 -07:00
Nick Martin
4e922fd709 remove ie8 hack from tests. for some reason it is no longer needed. 2013-10-08 21:30:39 -07:00
Nick Martin
57c87a403d OCD 2013-10-08 20:03:02 -07:00
Nick Martin
93c23470aa make a bunch of packages internal.
please remember to set this when making new packages.
2013-10-08 19:58:48 -07:00
David Greenspan
11aa6c65e2 call template callbacks in Deps.nonreactive 2013-10-08 19:03:09 -07:00
David Greenspan
d1e6bd1a4f spacebars: prettier code gen pretty-printing 2013-10-08 19:02:42 -07:00
Avital Oliver
8df574c68a Don't crash on template destroyed callback 2013-10-08 15:02:52 -07:00
Nick Martin
9f2188b5da Not sure why, but opera is better now (including old versions). I guess one of the minimongo changes caused the ordering to be different. 2013-10-08 00:42:52 -07:00
Nick Martin
28082f33e1 Fix issue where login callbacks could be called multiple times on reconnect. 2013-10-08 00:10:33 -07:00
Nick Martin
e5dd8f4f8e Better error handling if resetPassword fails. Also, handle setLoginToken(null) better. 2013-10-07 23:33:04 -07:00
Nick Martin
b09f206753 Specify userId in one other expireTokens call. Add a check to make sure we don't do it again. 2013-10-07 21:53:57 -07:00
Nick Martin
468eb6a1bf Fix typo in index name. We were not indexing password reset tokens correctly. 2013-10-07 21:53:57 -07:00
Nick Martin
9bad3afcfb Fix reset email test. NOTE: still needs work on error handling. 2013-10-07 21:53:57 -07:00
Nick Martin
f9504f215e Add test parameter so we only expire tokens for our user, not everyone. 2013-10-07 21:53:57 -07:00
Nick Martin
bc8406d8a0 add XXX note 2013-10-07 21:53:56 -07:00
Nick Martin
2deb0e9b62 break 'long series' test into smaller tests. 2013-10-07 21:53:56 -07:00
Nick Martin
6ca55ec189 Remember to call this._setLoginToken the other places we call this.setUserId
This makes me feel that this._setLoginToken is the wrong pattern even more strongly.
2013-10-07 21:53:56 -07:00
Slava Kim
799dd35319 Merge branch 'minimongo-near' into devel
Conflicts:
	History.md
	LICENSE.txt
2013-10-07 16:55:10 -07:00
Slava Kim
24b3ca13e1 Another test for minimongo $near inside $and clause
It throws no matter how deep is $near.
2013-10-07 16:50:27 -07:00
Slava Kim
d1518f4f17 Package wrapper for geojson-utils package to keep original code unchanged. 2013-10-07 16:07:45 -07:00
David Greenspan
9500f5ffa4 test reactive case as well 2013-10-07 15:39:25 -07:00
David Greenspan
b88e40b0b7 hack for lexical scope of {{> content}} 2013-10-07 15:37:56 -07:00
Slava Kim
7c9122ef09 Make geojson-utils a strong dependency of minimongo. 2013-10-07 14:30:54 -07:00
David Greenspan
7a112872fd fix {{> content}} in {{#if} with messy hack 2013-10-07 14:27:20 -07:00
David Greenspan
96af53db96 get rid of component.$
We still have domrange.$, a.k.a. component.dom.$

Think about aliasing it as component.$ again in the future, but watch out for helpers called "$" since the current plan puts component methods and helpers in the same namespace.
2013-10-07 11:27:20 -07:00
David Greenspan
f8e3e5a7e2 remove broken tests and dead code 2013-10-07 11:16:58 -07:00
Avital Oliver
d8a70707e6 slightly better error 2013-10-07 11:13:30 -07:00
David Greenspan
84873c8a22 fix argument binding with dots in Spacebars.index 2013-10-07 10:45:13 -07:00
David Greenspan
3f93c386ce _.each doesn't work on false all of a sudden
(but still works on `null`)
2013-10-07 10:28:23 -07:00
David Greenspan
2378cbfbdc Merge branch 'devel' into shark 2013-10-07 10:25:20 -07:00
David Greenspan
5a99b948d2 fix login buttons 2013-10-05 18:17:17 -07:00
David Greenspan
287f7ab1f3 fix keyword args 2013-10-05 18:01:18 -07:00
David Greenspan
7cebd55c7f Fix dots in mustaches by rewriting Spacebars.index
Also comment out failing old tests in "spacebars" package
2013-10-05 16:57:15 -07:00
David Greenspan
5eeabd985c fix typos in tests 2013-10-05 15:14:26 -07:00