github/node-v0.x-archive
1
1
Fork 0
mirror of https://github.com/nodejs/node-v0.x-archive.git synced 2026-04-28 03:01:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add HandleScope to http-parser binding"

Browse Source 
This commit did not actually fix the production crashes.

This reverts commit 73cf8e82e7.
This commit is contained in:
Ryan Dahl
2011-12-28 14:08:19 -08:00
parent d483acc5d9
commit 448c5e07ca
1 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/node_http_parser.cc
View File

@@ -119,17 +119,15 @@ static size_t current_buffer_len;
#define HTTP_CB(name) \
static int name(http_parser* p_) { \
HandleScope scope; \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(); \
} \
int always_inline name##_()
static int name(http_parser* p_) { \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(); \
} \
int always_inline name##_()
#define HTTP_DATA_CB(name) \
static int name(http_parser* p_, const char* at, size_t length) { \
HandleScope scope; \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(at, length); \
} \
@@ -214,12 +212,10 @@ struct StringPtr {
Handle<String> ToString() const {
HandleScope scope;
if (str_) {
return scope.Close(String::New(str_, size_));
} else {
return scope.Close(String::Empty());
}
if (str_)
return String::New(str_, size_);
else
return String::Empty();
}
@@ -517,8 +513,6 @@ public:
private:
Local<Array> CreateHeaders() {
HandleScope scope;
// num_values_ is either -1 or the entry # of the last header
// so num_values_ == 0 means there's a single header
Local<Array> headers = Array::New(2 * (num_values_ + 1));
@@ -528,7 +522,7 @@ private:
headers->Set(2 * i + 1, values_[i].ToString());
}
return scope.Close(headers);
return headers;
}