github/node-v0.x-archive
1
1
Fork 0
mirror of https://github.com/nodejs/node-v0.x-archive.git synced 2026-04-28 03:01:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

print warning on process.ENV

Browse Source
This commit is contained in:
Ryan Dahl
2010-12-02 15:59:35 -08:00
parent 558e5ba2b0
commit ea9006a5bc
1 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/node.cc
View File

@@ -1531,6 +1531,17 @@ static Handle<Value> EnvGetter(Local<String> property,
}
static bool ENV_warning = false;
static Handle<Value> EnvGetterWarn(Local<String> property,
const AccessorInfo& info) {
if (!ENV_warning) {
ENV_warning = true;
fprintf(stderr, "(node) Use process.env instead of process.ENV\r\n");
}
return EnvGetter(property, info);
}
static Handle<Value> EnvSetter(Local<String> property,
Local<Value> value,
const AccessorInfo& info) {
@@ -1630,13 +1641,27 @@ static void Load(int argc, char *argv[]) {
// create process.env
Local<ObjectTemplate> envTemplate = ObjectTemplate::New();
envTemplate->SetNamedPropertyHandler(EnvGetter, EnvSetter, EnvQuery, EnvDeleter, EnvEnumerator, Undefined());
// assign process.ENV
envTemplate->SetNamedPropertyHandler(EnvGetter,
EnvSetter,
EnvQuery,
EnvDeleter,
EnvEnumerator,
Undefined());
Local<Object> env = envTemplate->NewInstance();
process->Set(String::NewSymbol("ENV"), env);
process->Set(String::NewSymbol("env"), env);
// create process.ENV
// TODO: remove me at some point.
Local<ObjectTemplate> ENVTemplate = ObjectTemplate::New();
ENVTemplate->SetNamedPropertyHandler(EnvGetterWarn,
EnvSetter,
EnvQuery,
EnvDeleter,
EnvEnumerator,
Undefined());
Local<Object> ENV = ENVTemplate->NewInstance();
process->Set(String::NewSymbol("ENV"), ENV);
process->Set(String::NewSymbol("pid"), Integer::New(getpid()));
// -e, --eval