github/openNDS
1
1
Fork 0
mirror of https://github.com/openNDS/openNDS.git synced 2026-05-04 03:01:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix - inadvertant memory overwrite when customdata is null

Browse Source 
Signed-off-by: Rob White <rob@blue-wave.net>
This commit is contained in:
Rob White
2026-03-13 13:55:45 +00:00
parent 7ca65d1f26
commit f0494df4d2
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/auth.c
View File

@@ -276,6 +276,7 @@ static int binauth_action(t_client *client, const char *reason, const char *cust
char *deauth = "deauth";
char *client_auth = "client_auth";
char *ndsctl_auth = "ndsctl_auth";
char *customdata_raw;
char *customdata_enc;
char *binauthcmd;
int ret = 1;
@@ -283,15 +284,16 @@ static int binauth_action(t_client *client, const char *reason, const char *cust
if (config->binauth) {
debug(LOG_DEBUG, "client->custom=%s", client->custom);
customdata_enc = safe_calloc(CUSTOM_ENC);
if (!client->custom || strlen(client->custom) == 0) {
customdata="none";
customdata_raw = safe_strdup("none");
uh_urlencode(customdata_enc, CUSTOM_ENC, customdata_raw, strlen(customdata_raw));
free (customdata_raw);
} else {
customdata=client->custom;
uh_urlencode(customdata_enc, CUSTOM_ENC, customdata, strlen(customdata));
}
customdata_enc = safe_calloc(CUSTOM_ENC);
uh_urlencode(customdata_enc, CUSTOM_ENC, customdata, strlen(customdata));
debug(LOG_DEBUG, "binauth_action: customdata_enc [%s]", customdata_enc);
// get client's current session start and end
@@ -351,6 +353,7 @@ static int binauth_action(t_client *client, const char *reason, const char *cust
ndsctl_unlock();
}
}
return rc;
}
// No binauth configured, so good to go