github/openclaw
1
1
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-03 03:03:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Slack: include stacked modal lifecycle context

Browse Source
This commit is contained in:
Colin
2026-02-16 14:05:43 -05:00
committed by Peter Steinberger
parent ce973332f6
commit bd20c1e24d
2 changed files with 81 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/slack/monitor/events/interactions.test.ts
View File

@@ -30,6 +30,10 @@ type RegisteredViewHandler = (args: {
view?: {
id?: string;
callback_id?: string;
root_view_id?: string;
previous_view_id?: string;
external_id?: string;
hash?: string;
state?: { values?: Record<string, Record<string, Record<string, unknown>>> };
};
};
@@ -44,6 +48,10 @@ type RegisteredViewClosedHandler = (args: {
id?: string;
callback_id?: string;
private_metadata?: string;
root_view_id?: string;
previous_view_id?: string;
external_id?: string;
hash?: string;
state?: { values?: Record<string, Record<string, Record<string, unknown>>> };
};
is_cleared?: boolean;
@@ -604,6 +612,10 @@ describe("registerSlackInteractionEvents", () => {
view: {
id: "V123",
callback_id: "openclaw:deploy_form",
root_view_id: "VROOT",
previous_view_id: "VPREV",
external_id: "deploy-ext-1",
hash: "view-hash-1",
private_metadata: JSON.stringify({ channelId: "D123", channelType: "im" }),
state: {
values: {
@@ -642,6 +654,11 @@ describe("registerSlackInteractionEvents", () => {
viewId: string;
userId: string;
routedChannelId?: string;
rootViewId?: string;
previousViewId?: string;
externalId?: string;
viewHash?: string;
isStackedView?: boolean;
inputs: Array<{ actionId: string; selectedValues?: string[]; inputValue?: string }>;
};
expect(payload).toMatchObject({
@@ -651,6 +668,11 @@ describe("registerSlackInteractionEvents", () => {
viewId: "V123",
userId: "U777",
routedChannelId: "D123",
rootViewId: "VROOT",
previousViewId: "VPREV",
externalId: "deploy-ext-1",
viewHash: "view-hash-1",
isStackedView: true,
});
expect(payload.inputs).toEqual(
expect.arrayContaining([
@@ -939,6 +961,10 @@ describe("registerSlackInteractionEvents", () => {
view: {
id: "V900",
callback_id: "openclaw:deploy_form",
root_view_id: "VROOT900",
previous_view_id: "VPREV900",
external_id: "deploy-ext-900",
hash: "view-hash-900",
private_metadata: JSON.stringify({ sessionKey: "agent:main:slack:channel:C99" }),
state: {
values: {
@@ -972,6 +998,11 @@ describe("registerSlackInteractionEvents", () => {
userId: string;
isCleared: boolean;
privateMetadata: string;
rootViewId?: string;
previousViewId?: string;
externalId?: string;
viewHash?: string;
isStackedView?: boolean;
inputs: Array<{ actionId: string; selectedValues?: string[] }>;
};
expect(payload).toMatchObject({
@@ -982,6 +1013,11 @@ describe("registerSlackInteractionEvents", () => {
userId: "U900",
isCleared: true,
privateMetadata: JSON.stringify({ sessionKey: "agent:main:slack:channel:C99" }),
rootViewId: "VROOT900",
previousViewId: "VPREV900",
externalId: "deploy-ext-900",
viewHash: "view-hash-900",
isStackedView: true,
});
expect(payload.inputs).toEqual(
expect.arrayContaining([

45
src/slack/monitor/events/interactions.ts
View File

@@ -348,6 +348,31 @@ function resolveModalSessionRouting(params: {
};
}
function summarizeSlackViewLifecycleContext(view: {
root_view_id?: string;
previous_view_id?: string;
external_id?: string;
hash?: string;
}): {
rootViewId?: string;
previousViewId?: string;
externalId?: string;
viewHash?: string;
isStackedView?: boolean;
} {
const rootViewId = view.root_view_id;
const previousViewId = view.previous_view_id;
const externalId = view.external_id;
const viewHash = view.hash;
return {
rootViewId,
previousViewId,
externalId,
viewHash,
isStackedView: Boolean(previousViewId),
};
}
export function registerSlackInteractionEvents(params: { ctx: SlackMonitorContext }) {
const { ctx } = params;
if (typeof ctx.app.action !== "function") {
@@ -513,6 +538,10 @@ export function registerSlackInteractionEvents(params: { ctx: SlackMonitorContex
id?: string;
callback_id?: string;
private_metadata?: string;
root_view_id?: string;
previous_view_id?: string;
external_id?: string;
hash?: string;
state?: { values?: unknown };
};
};
@@ -532,6 +561,12 @@ export function registerSlackInteractionEvents(params: { ctx: SlackMonitorContex
viewId,
userId,
teamId: typedBody.team?.id,
...summarizeSlackViewLifecycleContext({
root_view_id: typedBody.view?.root_view_id,
previous_view_id: typedBody.view?.previous_view_id,
external_id: typedBody.view?.external_id,
hash: typedBody.view?.hash,
}),
privateMetadata: typedBody.view?.private_metadata,
routedChannelId: sessionRouting.channelId,
routedChannelType: sessionRouting.channelType,
@@ -576,6 +611,10 @@ export function registerSlackInteractionEvents(params: { ctx: SlackMonitorContex
id?: string;
callback_id?: string;
private_metadata?: string;
root_view_id?: string;
previous_view_id?: string;
external_id?: string;
hash?: string;
state?: { values?: unknown };
};
is_cleared?: boolean;
@@ -596,6 +635,12 @@ export function registerSlackInteractionEvents(params: { ctx: SlackMonitorContex
viewId,
userId,
teamId: typedBody.team?.id,
...summarizeSlackViewLifecycleContext({
root_view_id: typedBody.view?.root_view_id,
previous_view_id: typedBody.view?.previous_view_id,
external_id: typedBody.view?.external_id,
hash: typedBody.view?.hash,
}),
isCleared: typedBody.is_cleared === true,
privateMetadata: typedBody.view?.private_metadata,
routedChannelId: sessionRouting.channelId,