github/openclaw
1
1
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-02-19 18:39:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

test(cron): dedupe delayed-timer job assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-19 08:31:28 +00:00
parent cdee433332
commit e4bb6e044d
1 changed files with 42 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
src/cron/service.every-jobs-fire.test.ts
View File

@@ -14,6 +14,34 @@ const { makeStorePath } = createCronStoreHarness();
installCronTestHooks({ logger: noopLogger });
describe("CronService interval/cron jobs fire on time", () => {
const runLateTimerAndLoadJob = async ({
cron,
finished,
jobId,
firstDueAt,
}: {
cron: CronService;
finished: { waitForOk: (id: string) => Promise<unknown> };
jobId: string;
firstDueAt: number;
}) => {
vi.setSystemTime(new Date(firstDueAt + 5));
await vi.runOnlyPendingTimersAsync();
await finished.waitForOk(jobId);
const jobs = await cron.list({ includeDisabled: true });
return jobs.find((current) => current.id === jobId);
};
const expectMainSystemEvent = (
enqueueSystemEvent: ReturnType<typeof vi.fn>,
expectedText: string,
) => {
expect(enqueueSystemEvent).toHaveBeenCalledWith(
expectedText,
expect.objectContaining({ agentId: undefined }),
);
};
it("fires an every-type main job when the timer fires a few ms late", async () => {
const store = await makeStorePath();
const { cron, enqueueSystemEvent, finished } = createStartedCronServiceWithFinishedBarrier({
@@ -34,18 +62,13 @@ describe("CronService interval/cron jobs fire on time", () => {
const firstDueAt = job.state.nextRunAtMs!;
expect(firstDueAt).toBe(Date.parse("2025-12-13T00:00:00.000Z") + 10_000);
// Simulate setTimeout firing 5ms late (the race condition).
vi.setSystemTime(new Date(firstDueAt + 5));
await vi.runOnlyPendingTimersAsync();
await finished.waitForOk(job.id);
const jobs = await cron.list({ includeDisabled: true });
const updated = jobs.find((current) => current.id === job.id);
expect(enqueueSystemEvent).toHaveBeenCalledWith(
"tick",
expect.objectContaining({ agentId: undefined }),
);
const updated = await runLateTimerAndLoadJob({
cron,
finished,
jobId: job.id,
firstDueAt,
});
expectMainSystemEvent(enqueueSystemEvent, "tick");
expect(updated?.state.lastStatus).toBe("ok");
// nextRunAtMs must advance by at least one full interval past the due time.
expect(updated?.state.nextRunAtMs).toBeGreaterThanOrEqual(firstDueAt + 10_000);
@@ -76,18 +99,13 @@ describe("CronService interval/cron jobs fire on time", () => {
const firstDueAt = job.state.nextRunAtMs!;
// Simulate setTimeout firing 5ms late.
vi.setSystemTime(new Date(firstDueAt + 5));
await vi.runOnlyPendingTimersAsync();
await finished.waitForOk(job.id);
const jobs = await cron.list({ includeDisabled: true });
const updated = jobs.find((current) => current.id === job.id);
expect(enqueueSystemEvent).toHaveBeenCalledWith(
"cron-tick",
expect.objectContaining({ agentId: undefined }),
);
const updated = await runLateTimerAndLoadJob({
cron,
finished,
jobId: job.id,
firstDueAt,
});
expectMainSystemEvent(enqueueSystemEvent, "cron-tick");
expect(updated?.state.lastStatus).toBe("ok");
// nextRunAtMs should be the next whole-minute boundary (60s later).
expect(updated?.state.nextRunAtMs).toBe(firstDueAt + 60_000);