kv: write recovered state summaries to stateSummaryBucket (#15896)

* kv: write recovered state summaries to stateSummaryBucket

* Create MozirDmitriy_fix_kv-recover-state-summurt-bucket.md

* add a test

beacon-chain/db/kv/checkpoint.go

@@ -132,6 +132,6 @@ func recoverStateSummary(ctx context.Context, tx *bolt.Tx, root []byte) error {
 	if err != nil {
 		return err
 	}
-	summaryBucket := tx.Bucket(stateBucket)
+	summaryBucket := tx.Bucket(stateSummaryBucket)
 	return summaryBucket.Put(root, summaryEnc)
 }

beacon-chain/db/kv/checkpoint_test.go

@@ -137,3 +137,32 @@ func TestStore_FinalizedCheckpoint_StateMustExist(t *testing.T) {
 
 	require.ErrorContains(t, errMissingStateForCheckpoint.Error(), db.SaveFinalizedCheckpoint(ctx, cp))
 }
+
+// Regression test: verify that saving a checkpoint triggers recovery which writes
+// the state summary into the correct stateSummaryBucket so that HasStateSummary/StateSummary see it.
+func TestRecoverStateSummary_WritesToStateSummaryBucket(t *testing.T) {
+	db := setupDB(t)
+	ctx := t.Context()
+
+	// Create a block without saving a state or summary, so recovery is needed.
+	blk := util.HydrateSignedBeaconBlock(&ethpb.SignedBeaconBlock{})
+	root, err := blk.Block.HashTreeRoot()
+	require.NoError(t, err)
+	wsb, err := blocks.NewSignedBeaconBlock(blk)
+	require.NoError(t, err)
+	require.NoError(t, db.SaveBlock(ctx, wsb))
+
+	// Precondition: summary not present yet.
+	require.Equal(t, false, db.HasStateSummary(ctx, root))
+
+	// Saving justified checkpoint should trigger recovery path calling recoverStateSummary.
+	cp := &ethpb.Checkpoint{Epoch: 2, Root: root[:]}
+	require.NoError(t, db.SaveJustifiedCheckpoint(ctx, cp))
+
+	// Postcondition: summary is visible via the public summary APIs (which read stateSummaryBucket).
+	require.Equal(t, true, db.HasStateSummary(ctx, root))
+	summary, err := db.StateSummary(ctx, root)
+	require.NoError(t, err)
+	require.NotNil(t, summary)
+	assert.DeepEqual(t, &ethpb.StateSummary{Slot: blk.Block.Slot, Root: root[:]}, summary)
+}

changelog/MozirDmitriy_fix_kv-recover-state-summurt-bucket.md

@@ -0,0 +1,3 @@
+### Fixed
+
+- Fix recoverStateSummary to persist state summaries in stateSummaryBucket instead of stateBucket (#15896).