github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

periodically_call_remote does not need data-observe=true

Browse Source
This commit is contained in:
Erik St. Martin
2010-01-26 11:06:58 -05:00
committed by Stefan Penner
parent 6a8da2053e
commit 0215466832
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
actionpack/lib/action_view/helpers/ajax_helper.rb
View File

@@ -402,6 +402,9 @@ module ActionView
attributes = extract_observer_attributes!(options)
attributes["data-periodical"] = true
# periodically_call_remote does not need data-observe=true
attributes.delete('data-observe')
script_decorator(attributes)
end

4
actionpack/test/template/ajax_helper_test.rb
View File

@@ -160,13 +160,13 @@ class AjaxHelperTest < AjaxHelperBaseTest
end
test "periodically_call_remote" do
assert_dom_equal %(<script data-url=\"http://www.example.com/mehr_bier\" data-observe=\"true\" data-update-success=\"schremser_bier\" type=\"application/json\" data-periodical=\"true\"></script>),
assert_dom_equal %(<script data-url=\"http://www.example.com/mehr_bier\" data-update-success=\"schremser_bier\" type=\"application/json\" data-periodical=\"true\"></script>),
periodically_call_remote(:update => "schremser_bier", :url => { :action => "mehr_bier" })
end
test "periodically_call_remote_with_frequency" do
assert_dom_equal(
"<script data-periodical=\"true\" data-url=\"http://www.example.com/\" data-observe=\"true\" type=\"application/json\" data-frequency=\"2\"></script>",
"<script data-periodical=\"true\" data-url=\"http://www.example.com/\" type=\"application/json\" data-frequency=\"2\"></script>",
periodically_call_remote(:frequency => 2)
)
end