github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-05 03:35:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Include empty has_many/has_and_belongs_to_many associations as empty array tags when serializing to XML

Browse Source 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Tobias Lütke
2007-07-09 18:13:24 +00:00
parent 1241615692
commit 049b1440a3
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
activerecord/lib/active_record/xml_serialization.rb
View File

@@ -205,13 +205,10 @@ module ActiveRecord #:nodoc:
case @record.class.reflect_on_association(association).macro
when :has_many, :has_and_belongs_to_many
records = @record.send(association).to_a
unless records.empty?
tag = association.to_s
tag = tag.dasherize if dasherize?
builder.tag!(tag, :type => :array) do
records.each { |r| r.to_xml(opts.merge(:root=>r.class.to_s.underscore)) }
end
tag = association.to_s
tag = tag.dasherize if dasherize?
builder.tag!(tag, :type => :array) do
records.each { |r| r.to_xml(opts.merge(:root=>r.class.to_s.underscore)) }
end
when :has_one, :belongs_to
if record = @record.send(association)

8
activerecord/test/xml_serialization_test.rb
View File

@@ -162,4 +162,12 @@ class DatabaseConnectedXmlSerializationTest < Test::Unit::TestCase
assert_match %r{^ <label>.*</label>}, xml
assert_no_match %r{^ <label>}, xml
end
def test_should_include_empty_has_many_as_empty_array
authors(:david).posts.delete_all
xml = authors(:david).to_xml :include=>:posts, :indent => 0
assert_match %r{<posts type="array"></posts>}, xml
end
end