assert_deprecated matches any warning caught in block

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Jeremy Kemper
2006-09-15 03:56:25 +00:00
parent 643571ca25
commit 069b0eaf0b
2 changed files with 12 additions and 3 deletions

View File

@@ -86,11 +86,11 @@ module ActiveSupport
module Assertions
def assert_deprecated(match = nil, &block)
last = collect_deprecations(&block).last
assert last, "Expected a deprecation warning within the block but received none"
warnings = collect_deprecations(&block)
assert !warnings.empty?, "Expected a deprecation warning within the block but received none"
if match
match = Regexp.new(Regexp.escape(match)) unless match.is_a?(Regexp)
assert_match match, last, "Deprecation warning didn't match #{match}: #{last}"
assert warnings.any? { |w| w =~ match }, "No deprecation warning matched #{match}: #{warnings.join(', ')}"
end
end

View File

@@ -78,6 +78,15 @@ class DeprecationTest < Test::Unit::TestCase
end
end
def test_assert_deprecated_matches_any_warning
assert_deprecated 'abc' do
ActiveSupport::Deprecation.warn 'abc'
ActiveSupport::Deprecation.warn 'def'
end
rescue Test::Unit::AssertionFailedError
flunk 'assert_deprecated should match any warning in block, not just the last one'
end
def test_silence
ActiveSupport::Deprecation.silence do
assert_not_deprecated { @dtc.partially }