remove the check for needs_type_condition? because ensure_proper_type will pick up the type column

This commit is contained in:
Aaron Patterson
2011-06-27 20:44:39 -07:00
parent 992b3b5e06
commit 196f92f366
2 changed files with 4 additions and 3 deletions

View File

@@ -1916,8 +1916,9 @@ MSG
# do Reply.new without having to set <tt>Reply[Reply.inheritance_column] = "Reply"</tt> yourself.
# No such attribute would be set for objects of the Message class in that example.
def ensure_proper_type
unless self.class.descends_from_active_record?
write_attribute(self.class.inheritance_column, self.class.sti_name)
klass = self.class
if klass.finder_needs_type_condition?
write_attribute(klass.inheritance_column, klass.sti_name)
end
end

View File

@@ -48,7 +48,7 @@ module ActiveRecord
current_scope.scope_for_create
else
# Return an empty hash in the simple case
return {} unless finder_needs_type_condition? || default_scopes.any?
return {} unless default_scopes.any?
scope = relation.clone
scope.default_scoped = true