mirror of
https://github.com/github/rails.git
synced 2026-04-26 03:00:59 -04:00
removes unused Object#subclasses_of
This commit is contained in:
@@ -36,18 +36,6 @@ class Class
|
||||
end
|
||||
|
||||
class Object
|
||||
# Exclude this class unless it's a subclass of our supers and is defined.
|
||||
# We check defined? in case we find a removed class that has yet to be
|
||||
# garbage collected. This also fails for anonymous classes -- please
|
||||
# submit a patch if you have a workaround.
|
||||
def subclasses_of(*superclasses) #:nodoc:
|
||||
subclasses = []
|
||||
superclasses.each do |klass|
|
||||
subclasses.concat klass.descendents.select {|k| k.name.blank? || k.reachable?}
|
||||
end
|
||||
subclasses
|
||||
end
|
||||
|
||||
def extended_by #:nodoc:
|
||||
ancestors = class << self; ancestors end
|
||||
ancestors.select { |mod| mod.class == Module } - [ Object, Kernel ]
|
||||
|
||||
@@ -40,55 +40,6 @@ class Foo
|
||||
include Bar
|
||||
end
|
||||
|
||||
class ClassExtTest < Test::Unit::TestCase
|
||||
def test_subclasses_of_should_find_nested_classes
|
||||
assert Object.subclasses_of(ClassK).include?(Nested::ClassL)
|
||||
end
|
||||
|
||||
def test_subclasses_of_should_not_return_removed_classes
|
||||
# First create the removed class
|
||||
old_class = Nested.class_eval { remove_const :ClassL }
|
||||
new_class = Class.new(ClassK)
|
||||
Nested.const_set :ClassL, new_class
|
||||
assert_equal "Nested::ClassL", new_class.name # Sanity check
|
||||
|
||||
subclasses = Object.subclasses_of(ClassK)
|
||||
assert subclasses.include?(new_class)
|
||||
assert ! subclasses.include?(old_class)
|
||||
ensure
|
||||
Nested.const_set :ClassL, old_class unless defined?(Nested::ClassL)
|
||||
end
|
||||
|
||||
def test_subclasses_of_should_not_trigger_const_missing
|
||||
const_missing = false
|
||||
Nested.on_const_missing { const_missing = true }
|
||||
|
||||
subclasses = Object.subclasses_of ClassK
|
||||
assert !const_missing
|
||||
assert_equal [ Nested::ClassL ], subclasses
|
||||
|
||||
removed = Nested.class_eval { remove_const :ClassL } # keep it in memory
|
||||
subclasses = Object.subclasses_of ClassK
|
||||
assert !const_missing
|
||||
assert subclasses.empty?
|
||||
ensure
|
||||
Nested.const_set :ClassL, removed unless defined?(Nested::ClassL)
|
||||
end
|
||||
|
||||
def test_subclasses_of_with_multiple_roots
|
||||
classes = Object.subclasses_of(ClassI, ClassK)
|
||||
assert_equal %w(ClassJ Nested::ClassL), classes.collect(&:to_s).sort
|
||||
end
|
||||
|
||||
def test_subclasses_of_doesnt_find_anonymous_classes
|
||||
assert_equal [], Object.subclasses_of(Foo)
|
||||
bar = Class.new(Foo)
|
||||
assert_nothing_raised do
|
||||
assert_equal [bar], Object.subclasses_of(Foo)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
class ObjectTests < Test::Unit::TestCase
|
||||
def test_extended_by
|
||||
foo = Foo.new
|
||||
|
||||
Reference in New Issue
Block a user