github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Integer#even? and Integer#odd? are not needed for Ruby >= 1.8.7

Browse Source
This commit is contained in:
Xavier Noria
2009-11-09 21:46:16 +01:00
parent b6598c683b
commit 329e7f4441
6 changed files with 7 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
activerecord/lib/active_record/validations.rb
View File

@@ -1,5 +1,3 @@
require 'active_support/core_ext/integer/even_odd'
module ActiveRecord
# Raised by <tt>save!</tt> and <tt>create!</tt> when the record is invalid. Use the
# +record+ method to retrieve the record which did not validate.

2
activesupport/lib/active_support/core_ext/integer.rb
View File

@@ -1,3 +1,3 @@
require 'active_support/core_ext/integer/even_odd'
require 'active_support/core_ext/integer/multiple'
require 'active_support/core_ext/integer/inflections'
require 'active_support/core_ext/integer/time'

16
activesupport/lib/active_support/core_ext/integer/even_odd.rb
View File

@@ -1,16 +0,0 @@
class Integer
# Check whether the integer is evenly divisible by the argument.
def multiple_of?(number)
self % number == 0
end
# Is the integer a multiple of 2?
def even?
multiple_of? 2
end unless method_defined?(:even?)
# Is the integer not a multiple of 2?
def odd?
!even?
end unless method_defined?(:odd?)
end

6
activesupport/lib/active_support/core_ext/integer/multiple.rb Normal file
View File

@@ -0,0 +1,6 @@
class Integer
# Check whether the integer is evenly divisible by the argument.
def multiple_of?(number)
self % number == 0
end
end

2
activesupport/lib/active_support/ruby/shim.rb
View File

@@ -4,7 +4,6 @@
# Date next_year, next_month
# DateTime to_date, to_datetime, xmlschema
# Enumerable group_by, each_with_object, none?
# Integer even?, odd?
# Process Process.daemon
# REXML security fix
# String ord
@@ -13,7 +12,6 @@ require 'active_support'
require 'active_support/core_ext/date/calculations'
require 'active_support/core_ext/date_time/conversions'
require 'active_support/core_ext/enumerable'
require 'active_support/core_ext/integer/even_odd'
require 'active_support/core_ext/process/daemon'
require 'active_support/core_ext/string/conversions'
require 'active_support/core_ext/rexml'

16
activesupport/test/core_ext/integer_ext_test.rb
View File

@@ -2,22 +2,6 @@ require 'abstract_unit'
require 'active_support/core_ext/integer'
class IntegerExtTest < Test::Unit::TestCase
def test_even
assert [ -2, 0, 2, 4 ].all? { |i| i.even? }
assert ![ -1, 1, 3 ].all? { |i| i.even? }
assert 22953686867719691230002707821868552601124472329079.odd?
assert !22953686867719691230002707821868552601124472329079.even?
assert 22953686867719691230002707821868552601124472329080.even?
assert !22953686867719691230002707821868552601124472329080.odd?
end
def test_odd
assert ![ -2, 0, 2, 4 ].all? { |i| i.odd? }
assert [ -1, 1, 3 ].all? { |i| i.odd? }
assert 1000000000000000000000000000000000000000000000000000000001.odd?
end
def test_multiple_of
[ -7, 0, 7, 14 ].each { |i| assert i.multiple_of?(7) }
[ -7, 7, 14 ].each { |i| assert ! i.multiple_of?(6) }