github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

speed up duplicate migration detection

Browse Source
This commit is contained in:
Aaron Patterson
2010-10-03 16:39:48 -07:00
parent 40761c4bf3
commit 365c93b7cd
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
activerecord/lib/active_record/migration.rb
View File

@@ -507,6 +507,8 @@ module ActiveRecord
def migrations(path)
files = Dir["#{path}/[0-9]*_*.rb"]
seen = Hash.new false
migrations = files.inject([]) do |klasses, file|
version, name, scope = file.scan(/([0-9]+)_([_a-z0-9]*)\.?([_a-z0-9]*)?.rb/).first
name = name.camelize
@@ -514,13 +516,10 @@ module ActiveRecord
raise IllegalMigrationNameError.new(file) unless version
version = version.to_i
if klasses.detect { |m| m.version == version }
raise DuplicateMigrationVersionError.new(version)
end
raise DuplicateMigrationVersionError.new(version) if seen[version]
raise DuplicateMigrationNameError.new(name) if seen[[name, scope]]
if klasses.detect { |m| m.name == name && m.scope == scope }
raise DuplicateMigrationNameError.new(name)
end
seen[version] = seen[[name, scope]] = true
migration = MigrationProxy.new(name, version, file, scope)
klasses << migration