mirror of
https://github.com/github/rails.git
synced 2026-01-10 07:07:54 -05:00
Includes stale record in StaleObjectError
This commit is contained in:
@@ -99,6 +99,15 @@ module ActiveRecord
|
||||
#
|
||||
# Read more about optimistic locking in ActiveRecord::Locking module RDoc.
|
||||
class StaleObjectError < ActiveRecordError
|
||||
attr_reader :record
|
||||
|
||||
def initialize(record)
|
||||
@record = record
|
||||
end
|
||||
|
||||
def message
|
||||
"Attempted to update a stale object: #{record.class.name}"
|
||||
end
|
||||
end
|
||||
|
||||
# Raised when association is being configured improperly or
|
||||
|
||||
@@ -103,7 +103,7 @@ module ActiveRecord
|
||||
affected_rows = connection.update stmt
|
||||
|
||||
unless affected_rows == 1
|
||||
raise ActiveRecord::StaleObjectError, "Attempted to update a stale object: #{self.class.name}"
|
||||
raise ActiveRecord::StaleObjectError, self
|
||||
end
|
||||
|
||||
affected_rows
|
||||
@@ -127,7 +127,7 @@ module ActiveRecord
|
||||
affected_rows = self.class.unscoped.where(predicate).delete_all
|
||||
|
||||
unless affected_rows == 1
|
||||
raise ActiveRecord::StaleObjectError, "Attempted to delete a stale object: #{self.class.name}"
|
||||
raise ActiveRecord::StaleObjectError, self
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
@@ -125,6 +125,24 @@ class OptimisticLockingTest < ActiveRecord::TestCase
|
||||
assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
|
||||
end
|
||||
|
||||
def test_lock_exception_record
|
||||
p1 = Person.new(:first_name => 'mira')
|
||||
assert_equal 0, p1.lock_version
|
||||
|
||||
p1.first_name = 'mira2'
|
||||
p1.save!
|
||||
p2 = Person.find(p1.id)
|
||||
assert_equal 0, p1.lock_version
|
||||
assert_equal 0, p2.lock_version
|
||||
|
||||
p1.first_name = 'mira3'
|
||||
p1.save!
|
||||
|
||||
p2.first_name = 'sue'
|
||||
error = assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
|
||||
assert_equal(error.record.object_id, p2.object_id)
|
||||
end
|
||||
|
||||
def test_lock_new_with_nil
|
||||
p1 = Person.new(:first_name => 'anika')
|
||||
p1.save!
|
||||
@@ -141,7 +159,6 @@ class OptimisticLockingTest < ActiveRecord::TestCase
|
||||
assert_equal 1, p1.lock_version
|
||||
end
|
||||
|
||||
|
||||
def test_lock_column_name_existing
|
||||
t1 = LegacyThing.find(1)
|
||||
t2 = LegacyThing.find(1)
|
||||
|
||||
Reference in New Issue
Block a user