github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove fixture files with Windows incompatible filenames

Browse Source 
Windows doesn't allow `\ / : * ? " < > |` in filenames so create
the fixture files at runtime and ignore the incompatible ones when
running on Windows.
This commit is contained in:
Andrew White
2012-02-20 04:46:45 +00:00
parent b2e9bbdcff
commit 41c182c368
13 changed files with 86 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

111
actionpack/test/dispatch/static_test.rb
View File

@@ -1,4 +1,5 @@
require 'abstract_unit'
require 'rbconfig'
module StaticTests
def test_serves_dynamic_content
@@ -30,32 +31,84 @@ module StaticTests
assert_html "/foo/index.html", get("/foo")
end
def test_serves_static_file_with_encoded_pchar
assert_html "/foo/foo!bar.html", get("/foo/foo%21bar.html")
assert_html "/foo/foo$bar.html", get("/foo/foo%24bar.html")
assert_html "/foo/foo&bar.html", get("/foo/foo%26bar.html")
assert_html "/foo/foo'bar.html", get("/foo/foo%27bar.html")
assert_html "/foo/foo(bar).html", get("/foo/foo%28bar%29.html")
assert_html "/foo/foo*bar.html", get("/foo/foo%2Abar.html")
assert_html "/foo/foo+bar.html", get("/foo/foo%2Bbar.html")
assert_html "/foo/foo,bar.html", get("/foo/foo%2Cbar.html")
assert_html "/foo/foo;bar.html", get("/foo/foo%3Bbar.html")
assert_html "/foo/foo:bar.html", get("/foo/foo%3Abar.html")
assert_html "/foo/foo@bar.html", get("/foo/foo%40bar.html")
def test_serves_static_file_with_exclamation_mark_in_filename
with_static_file "/foo/foo!bar.html" do |file|
assert_html file, get("/foo/foo%21bar.html")
assert_html file, get("/foo/foo!bar.html")
end
end
def test_serves_static_file_with_unencoded_pchar
assert_html "/foo/foo!bar.html", get("/foo/foo!bar.html")
assert_html "/foo/foo$bar.html", get("/foo/foo$bar.html")
assert_html "/foo/foo&bar.html", get("/foo/foo&bar.html")
assert_html "/foo/foo'bar.html", get("/foo/foo'bar.html")
assert_html "/foo/foo(bar).html", get("/foo/foo(bar).html")
assert_html "/foo/foo*bar.html", get("/foo/foo*bar.html")
assert_html "/foo/foo+bar.html", get("/foo/foo+bar.html")
assert_html "/foo/foo,bar.html", get("/foo/foo,bar.html")
assert_html "/foo/foo;bar.html", get("/foo/foo;bar.html")
assert_html "/foo/foo:bar.html", get("/foo/foo:bar.html")
assert_html "/foo/foo@bar.html", get("/foo/foo@bar.html")
def test_serves_static_file_with_dollar_sign_in_filename
with_static_file "/foo/foo$bar.html" do |file|
assert_html file, get("/foo/foo%24bar.html")
assert_html file, get("/foo/foo$bar.html")
end
end
def test_serves_static_file_with_ampersand_in_filename
with_static_file "/foo/foo&bar.html" do |file|
assert_html file, get("/foo/foo%26bar.html")
assert_html file, get("/foo/foo&bar.html")
end
end
def test_serves_static_file_with_apostrophe_in_filename
with_static_file "/foo/foo'bar.html" do |file|
assert_html file, get("/foo/foo%27bar.html")
assert_html file, get("/foo/foo'bar.html")
end
end
def test_serves_static_file_with_parentheses_in_filename
with_static_file "/foo/foo(bar).html" do |file|
assert_html file, get("/foo/foo%28bar%29.html")
assert_html file, get("/foo/foo(bar).html")
end
end
def test_serves_static_file_with_plus_sign_in_filename
with_static_file "/foo/foo+bar.html" do |file|
assert_html file, get("/foo/foo%2Bbar.html")
assert_html file, get("/foo/foo+bar.html")
end
end
def test_serves_static_file_with_comma_in_filename
with_static_file "/foo/foo,bar.html" do |file|
assert_html file, get("/foo/foo%2Cbar.html")
assert_html file, get("/foo/foo,bar.html")
end
end
def test_serves_static_file_with_semi_colon_in_filename
with_static_file "/foo/foo;bar.html" do |file|
assert_html file, get("/foo/foo%3Bbar.html")
assert_html file, get("/foo/foo;bar.html")
end
end
def test_serves_static_file_with_at_symbol_in_filename
with_static_file "/foo/foo@bar.html" do |file|
assert_html file, get("/foo/foo%40bar.html")
assert_html file, get("/foo/foo@bar.html")
end
end
# Windows doesn't allow \ / : * ? " < > | in filenames
unless RbConfig::CONFIG['host_os'] =~ /mswin|mingw/
def test_serves_static_file_with_colon
with_static_file "/foo/foo:bar.html" do |file|
assert_html file, get("/foo/foo%3Abar.html")
assert_html file, get("/foo/foo:bar.html")
end
end
def test_serves_static_file_with_asterisk
with_static_file "/foo/foo*bar.html" do |file|
assert_html file, get("/foo/foo%2Abar.html")
assert_html file, get("/foo/foo*bar.html")
end
end
end
private
@@ -68,6 +121,14 @@ module StaticTests
def get(path)
Rack::MockRequest.new(@app).request("GET", path)
end
def with_static_file(file)
path = "#{FIXTURE_LOAD_PATH}/public" + file
File.open(path, "wb+") { |f| f.write(file) }
yield file
ensure
File.delete(path)
end
end
class StaticTest < ActiveSupport::TestCase
@@ -81,4 +142,4 @@ class StaticTest < ActiveSupport::TestCase
end
include StaticTests
end
end

1
actionpack/test/fixtures/public/foo/foo!bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo!bar.html

1
actionpack/test/fixtures/public/foo/foo$bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo$bar.html

1
actionpack/test/fixtures/public/foo/foo&bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo&bar.html

1
actionpack/test/fixtures/public/foo/foo'bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo'bar.html

1
actionpack/test/fixtures/public/foo/foo(bar).html vendored
View File

@@ -1 +0,0 @@
/foo/foo(bar).html

1
actionpack/test/fixtures/public/foo/foo*bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo*bar.html

1
actionpack/test/fixtures/public/foo/foo+bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo+bar.html

1
actionpack/test/fixtures/public/foo/foo,bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo,bar.html

1
actionpack/test/fixtures/public/foo/foo:bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo:bar.html

1
actionpack/test/fixtures/public/foo/foo;bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo;bar.html

1
actionpack/test/fixtures/public/foo/foo=bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo=bar.html

1
actionpack/test/fixtures/public/foo/foo@bar.html vendored
View File

@@ -1 +0,0 @@
/foo/foo@bar.html