github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor delete_records in HasManyAssociation

Browse Source
This commit is contained in:
Jon Leighton
2010-12-17 10:20:18 +00:00
committed by Aaron Patterson
parent b8153fd5a1
commit 57b9009893
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
activerecord/lib/active_record/associations/has_many_association.rb
View File

@@ -62,15 +62,16 @@ module ActiveRecord
def delete_records(records)
case @reflection.options[:dependent]
when :destroy
records.each { |r| r.destroy }
records.each(&:destroy)
when :delete_all
@reflection.klass.delete(records.map { |record| record.id })
@reflection.klass.delete(records.map(&:id))
else
relation = Arel::Table.new(@reflection.table_name)
stmt = relation.where(relation[@reflection.primary_key_name].eq(@owner.id).
and(relation[@reflection.klass.primary_key].in(records.map { |r| r.id }))
).compile_update(relation[@reflection.primary_key_name] => nil)
@owner.connection.update stmt.to_sql
updates = { @reflection.primary_key_name => nil }
conditions = { @reflection.association_primary_key => records.map(&:id) }
with_scope(@scope) do
@reflection.klass.update_all(updates, conditions)
end
@owner.class.update_counters(@owner.id, cached_counter_attribute_name => -records.size) if has_cached_counter?
end