Fixed that HashWithIndifferentAccess stringified all keys including symbols, ints, objects, and arrays #1162 [Nicholas Seckar]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
David Heinemeier Hansson
2005-05-19 19:13:30 +00:00
parent 7160ab1c18
commit 6375569484
3 changed files with 9 additions and 1 deletions

View File

@@ -1,5 +1,7 @@
*SVN*
* Fixed that HashWithIndifferentAccess stringified all keys including symbols, ints, objects, and arrays #1162 [Nicholas Seckar]
* Fixed Time#last_year to go back in time, not forward #1278 [fabien@odilat.com]
* Fixed the pluralization of analysis to analyses #1295 [seattle@rootimage.msu.edu]

View File

@@ -3,7 +3,7 @@ class HashWithIndifferentAccess < Hash
def initialize(constructor = {})
if constructor.is_a?(Hash)
super()
update(constructor.stringify_keys)
update(constructor)
else
super(constructor)
end

View File

@@ -110,4 +110,10 @@ class HashExtTest < Test::Unit::TestCase
h = {:user => {:id => 5}}.with_indifferent_access
['user', :user].each {|user| [:id, 'id'].each {|id| assert_equal 5, h[user][id], "h[#{user.inspect}][#{id.inspect}] should be 5"}}
end
def test_assorted_keys_not_stringified
original = {Object.new => 2, 1 => 2, [] => true}
indiff = original.with_indifferent_access
assert(!indiff.keys.any? {|k| k.kind_of? String}, "A key was converted to a string!")
end
end