mirror of
https://github.com/github/rails.git
synced 2026-04-26 03:00:59 -04:00
Merge pull request #1798 from jeroenj/cachesweeper-fix
Fixes an issue where cache sweepers with only after filters would have no controller object
This commit is contained in:
@@ -61,6 +61,7 @@ module ActionController #:nodoc:
|
||||
end
|
||||
|
||||
def after(controller)
|
||||
self.controller = controller
|
||||
callback(:after) if controller.perform_caching
|
||||
# Clean up, so that the controller can be collected after this request
|
||||
self.controller = nil
|
||||
|
||||
@@ -530,6 +530,11 @@ class FilterTest < ActionController::TestCase
|
||||
assert sweeper.before(TestController.new)
|
||||
end
|
||||
|
||||
def test_after_method_of_sweeper_should_always_return_nil
|
||||
sweeper = ActionController::Caching::Sweeper.send(:new)
|
||||
assert_nil sweeper.after(TestController.new)
|
||||
end
|
||||
|
||||
def test_non_yielding_around_filters_not_returning_false_do_not_raise
|
||||
controller = NonYieldingAroundFilterController.new
|
||||
controller.instance_variable_set "@filter_return_value", true
|
||||
|
||||
Reference in New Issue
Block a user