use array arithmetic rather than create sets

2026-04-26 03:00:59 -04:00 · 2010-12-20 14:24:04 -08:00
parent 37b67df7e4
commit 6e14feb978
1 changed files with 2 additions and 4 deletions
--- a/activerecord/lib/active_record/associations/association_collection.rb
+++ b/activerecord/lib/active_record/associations/association_collection.rb
@@ -344,12 +344,10 @@ module ActiveRecord
        other_array.each { |val| raise_on_type_mismatch(val) }

        load_target
-        other   = other_array.size < 100 ? other_array : other_array.to_set
-        current = @target.size < 100 ? @target : @target.to_set

        transaction do
-          delete(@target.select { |v| !other.include?(v) })
-          concat(other_array.select { |v| !current.include?(v) })
+          delete(@target - other_array)
+          concat(other_array - @target)
        end
      end