mirror of
https://github.com/github/rails.git
synced 2026-04-04 03:00:58 -04:00
Add label_tag helper for generating elements. Closes #10802 [DefV]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
@@ -1,5 +1,7 @@
|
||||
*SVN*
|
||||
|
||||
* Add label_tag helper for generating elements. #10802 [DefV]
|
||||
|
||||
* Introduce TemplateFinder to handle view paths and lookups. #10800 [Pratik Naik]
|
||||
|
||||
* Performance: optimize route recognition. Large speedup for apps with many resource routes. #10835 [oleganza]
|
||||
|
||||
@@ -114,6 +114,24 @@ module ActionView
|
||||
tag :input, { "type" => "text", "name" => name, "id" => name, "value" => value }.update(options.stringify_keys)
|
||||
end
|
||||
|
||||
# Creates a label field
|
||||
#
|
||||
# ==== Options
|
||||
# * Creates standard HTML attributes for the tag.
|
||||
#
|
||||
# ==== Examples
|
||||
# label_tag 'name'
|
||||
# # => <label for="name">Name</label>
|
||||
#
|
||||
# label_tag 'name', 'Your name'
|
||||
# # => <label for="name">Your Name</label>
|
||||
#
|
||||
# label_tag 'name', nil, :class => 'small_label'
|
||||
# # => <label for="name" class="small_label">Name</label>
|
||||
def label_tag(name, text = nil, options = {})
|
||||
content_tag :label, text || name.humanize, { "for" => name }.update(options.stringify_keys)
|
||||
end
|
||||
|
||||
# Creates a hidden form input field used to transmit data that would be lost due to HTTP's statelessness or
|
||||
# data that should be hidden from the user.
|
||||
#
|
||||
|
||||
@@ -188,6 +188,24 @@ class FormTagHelperTest < Test::Unit::TestCase
|
||||
assert_dom_equal expected, actual
|
||||
end
|
||||
|
||||
def test_label_tag_without_text
|
||||
actual = label_tag "title"
|
||||
expected = %(<label for="title">Title</label>)
|
||||
assert_dom_equal expected, actual
|
||||
end
|
||||
|
||||
def test_label_tag_with_text
|
||||
actual = label_tag "title", "My Title"
|
||||
expected = %(<label for="title">My Title</label>)
|
||||
assert_dom_equal expected, actual
|
||||
end
|
||||
|
||||
def test_label_tag_class_string
|
||||
actual = label_tag "title", "My Title", "class" => "small_label"
|
||||
expected = %(<label for="title" class="small_label">My Title</label>)
|
||||
assert_dom_equal expected, actual
|
||||
end
|
||||
|
||||
def test_boolean_optios
|
||||
assert_dom_equal %(<input checked="checked" disabled="disabled" id="admin" name="admin" readonly="readonly" type="checkbox" value="1" />), check_box_tag("admin", 1, true, 'disabled' => true, :readonly => "yes")
|
||||
assert_dom_equal %(<input checked="checked" id="admin" name="admin" type="checkbox" value="1" />), check_box_tag("admin", 1, true, :disabled => false, :readonly => nil)
|
||||
|
||||
Reference in New Issue
Block a user