github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't use regular rinder on calculations since scoping order blows

Browse Source 
PostreSQL.
This commit is contained in:
Emilio Tagua
2009-08-14 15:59:55 -03:00
parent 48c1e6d584
commit 796ec652ad
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
activerecord/lib/active_record/calculations.rb
View File

@@ -146,7 +146,13 @@ module ActiveRecord
join_dependency = ActiveRecord::Associations::ClassMethods::JoinDependency.new(self, merged_includes, construct_join(options[:joins], scope))
construct_finder_arel_with_included_associations(options, join_dependency)
else
construct_finder_arel(options)
arel_table(options[:from]).
join(construct_join(options[:joins], scope)).
where(construct_conditions(options[:conditions], scope)).
group(construct_group(options[:group], options[:having], scope)).
order(options[:order]).
take(options[:limit]).
skip(options[:offset])
end
if options[:group]
return execute_grouped_calculation(operation, column_name, options, relation)