dry up calls to arel.join()

2026-04-26 03:00:59 -04:00 · 2010-09-28 17:03:36 -07:00
parent ef2392f60b
commit 957e6fbe2a
1 changed files with 4 additions and 5 deletions
--- a/activerecord/lib/active_record/relation/query_methods.rb
+++ b/activerecord/lib/active_record/relation/query_methods.rb
@@ -159,14 +159,13 @@ module ActiveRecord
        case join
        when Hash, Array, Symbol
          if array_of_strings?(join)
-            join_string = join.join(' ')
-            arel.join(Arel::SqlLiteral.new(join_string))
+            join = Arel::SqlLiteral.new(join.join(' '))
          end
        when String
-          arel.join(Arel::SqlLiteral.new(join))
-        else
-          arel.join(join)
+          join = Arel::SqlLiteral.new(join)
        end
+
+        arel.join(join)
      end

      arel.joins(arel)