mirror of
https://github.com/github/rails.git
synced 2026-04-26 03:00:59 -04:00
Merge pull request #2527 from cesario/fix_2511
Methods like status and location are interfering with redirect_to [Closes #2511]
This commit is contained in:
@@ -58,8 +58,8 @@ module ActionController
|
||||
def redirect_to(*args)
|
||||
ActiveSupport::Notifications.instrument("redirect_to.action_controller") do |payload|
|
||||
result = super
|
||||
payload[:status] = self.status
|
||||
payload[:location] = self.location
|
||||
payload[:status] = response.status
|
||||
payload[:location] = response.location
|
||||
result
|
||||
end
|
||||
end
|
||||
@@ -97,4 +97,4 @@ module ActionController
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -4,6 +4,11 @@ class WorkshopsController < ActionController::Base
|
||||
end
|
||||
|
||||
class RedirectController < ActionController::Base
|
||||
# empty method not used anywhere to ensure methods like
|
||||
# `status` and `location` aren't called on `redirect_to` calls
|
||||
def status; render :text => 'called status'; end
|
||||
def location; render :text => 'called location'; end
|
||||
|
||||
def simple_redirect
|
||||
redirect_to :action => "hello_world"
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user