mirror of
https://github.com/github/rails.git
synced 2026-01-09 14:48:01 -05:00
Remove all deprecation warnings in activeresource
Signed-off-by: José Valim <jose.valim@gmail.com>
This commit is contained in:
committed by
José Valim
parent
7204bb0feb
commit
a18b73b43c
@@ -68,16 +68,8 @@ module ActiveResource
|
||||
|
||||
# Validate a resource and save (POST) it to the remote web service.
|
||||
# If any local validations fail - the save (POST) will not be attempted.
|
||||
def save_with_validation(options=nil)
|
||||
perform_validation = case options
|
||||
when Hash
|
||||
options[:validate] != false
|
||||
when NilClass
|
||||
true
|
||||
else
|
||||
ActiveSupport::Deprecation.warn "save(#{options}) is deprecated, please give save(:validate => #{options}) instead", caller
|
||||
options
|
||||
end
|
||||
def save_with_validation(options={})
|
||||
perform_validation = options[:validate] != false
|
||||
|
||||
# clear the remote validations so they don't interfere with the local
|
||||
# ones. Otherwise we get an endless loop and can never change the
|
||||
|
||||
@@ -36,14 +36,6 @@ class ValidationsTest < ActiveModel::TestCase
|
||||
assert p.save(:validate => false)
|
||||
end
|
||||
|
||||
def test_deprecated_save_without_validation
|
||||
p = new_project(:name => nil)
|
||||
assert !p.save
|
||||
assert_deprecated do
|
||||
assert p.save(false)
|
||||
end
|
||||
end
|
||||
|
||||
def test_validate_callback
|
||||
# we have a callback ensuring the description is longer than three letters
|
||||
p = new_project(:description => 'a')
|
||||
|
||||
Reference in New Issue
Block a user