github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-09 14:48:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Tidy up the "Specified column type for quote_value" changes

Browse Source 
This includes fixing typos in changelog, removing a deprecated
mocha/setup test require, and preferring the `column_for_attribute`
accessor over direct access to the columns_hash in the new code.

Conflicts:
	activerecord/CHANGELOG.md
	activerecord/lib/active_record/locking/optimistic.rb
This commit is contained in:
Ben Woosley
2013-07-20 20:15:48 -07:00
committed by Rafael Mendonça França
parent 33e1604b3e
commit b4dea61a42
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
activerecord/CHANGELOG.md
View File

@@ -1,9 +1,10 @@
## unreleased ##
* When using optimisitc locking, `update` whas not passing the column type to `quote_value`
* When using optimistic locking, `update` was not passing the column to `quote_value`
to allow the connection adapter to properly determine how to quote the value. This was
affecting certain databases that use specific colmn types.
Fix #6763
Fixes: #6763
*Alfred Wong*

1
activerecord/test/cases/locking_test.rb
View File

@@ -1,5 +1,4 @@
require 'thread'
require 'mocha/setup'
require "cases/helper"
require 'models/person'
require 'models/job'