github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Optimize memoized method if there are no arguments

Browse Source
This commit is contained in:
Joshua Peek
2008-08-06 20:21:15 -05:00
parent b2504f8ba0
commit be0d235a3b
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
activesupport/lib/active_support/memoizable.rb
View File

@@ -29,14 +29,24 @@ module ActiveSupport
raise "Already memoized #{symbol}" if method_defined?(:#{original_method})
alias #{original_method} #{symbol}
def #{symbol}(*args)
#{memoized_ivar} ||= {}
reload = args.pop if args.last == true || args.last == :reload
if instance_method(:#{symbol}).arity == 0
def #{symbol}(reload = false)
if !reload && defined? #{memoized_ivar}
#{memoized_ivar}
else
#{memoized_ivar} = #{original_method}.freeze
end
end
else
def #{symbol}(*args)
#{memoized_ivar} ||= {}
reload = args.pop if args.last == true || args.last == :reload
if !reload && #{memoized_ivar} && #{memoized_ivar}.has_key?(args)
#{memoized_ivar}[args]
else
#{memoized_ivar}[args] = #{original_method}(*args).freeze
if !reload && #{memoized_ivar} && #{memoized_ivar}.has_key?(args)
#{memoized_ivar}[args]
else
#{memoized_ivar}[args] = #{original_method}(*args).freeze
end
end
end
EOS