Correct BufferedLogger#level? checks. Closes #9806.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Jeremy Kemper
2007-10-07 18:54:36 +00:00
parent 2101c25faf
commit c90d31eb37
3 changed files with 10 additions and 1 deletions

View File

@@ -1,5 +1,7 @@
*SVN*
* Correct BufferedLogger#level? checks. #9806 [wildchild, Johan Sorensen]
* String#to_xs uses Eric Wong's fast_xs extension, if available, for Builder speedup. http://bogomips.org/fast_xs/ [Jeremy Kemper]
* Introduce BasicObject as Builder::BlankSlate for Ruby 1.9 forward compatibility. [Jeremy Kemper]

View File

@@ -70,7 +70,7 @@ module ActiveSupport
end
def #{severity.downcase}?
@level == #{severity}
#{severity} >= @level
end
EOT
end

View File

@@ -85,6 +85,13 @@ class BufferedLoggerTest < Test::Unit::TestCase
assert !@output.string.empty?, @logger.buffer.size
end
end
def test_should_know_if_its_loglevel_is_below_a_given_level
ActiveSupport::BufferedLogger::Severity.constants.each do |level|
@logger.level = ActiveSupport::BufferedLogger::Severity.const_get(level) - 1
assert @logger.send("#{level.downcase}?"), "didn't know if it was #{level.downcase}? or below"
end
end
def test_should_auto_flush_every_n_messages
@logger.auto_flushing = 5