github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

Avoid cloning in Base#attributes. Closes #11047 [juanjo.bazan]

Browse Source 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Michael Koziarski
2008-02-08 23:35:33 +00:00
parent 3d1a30bc59
commit cadb087deb
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
activerecord/lib/active_record/base.rb
View File

@@ -2212,21 +2212,24 @@ module ActiveRecord #:nodoc:
end
# Returns a hash of all the attributes with their names as keys and clones of their objects as values.
# Returns a hash of all the attributes with their names as keys and the values of the attributes as values.
def attributes(options = nil)
attributes = clone_attributes :read_attribute
attrs = {}
self.attribute_names.each do |name|
attrs[name]=read_attribute(name)
end
if options.nil?
attributes
attrs
else
if except = options[:except]
except = Array(except).collect { |attribute| attribute.to_s }
except.each { |attribute_name| attributes.delete(attribute_name) }
attributes
except.each { |attribute_name| attrs.delete(attribute_name) }
attrs
elsif only = options[:only]
only = Array(only).collect { |attribute| attribute.to_s }
attributes.delete_if { |key, value| !only.include?(key) }
attributes
attrs.delete_if { |key, value| !only.include?(key) }
attrs
else
raise ArgumentError, "Options does not specify :except or :only (#{options.keys.inspect})"
end