github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect specification path in GemDependency#from_directory_name

Browse Source 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
This commit is contained in:
Matt Jones
2009-06-09 12:26:52 -04:00
committed by Michael Koziarski
parent 69bc2043f9
commit d7e0cb05cc
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
railties/lib/rails/gem_dependency.rb
View File

@@ -34,7 +34,7 @@ module Rails
name = directory_name_parts[0..-2].join('-')
version = directory_name_parts.last
result = self.new(name, :version => version)
spec_filename = File.join(unpacked_path, directory_name, '.specification')
spec_filename = File.join(directory_name, '.specification')
if load_spec
raise "Missing specification file in #{File.dirname(spec_filename)}. Perhaps you need to do a 'rake gems:refresh_specs'?" unless File.exists?(spec_filename)
spec = YAML::load_file(spec_filename)

7
railties/test/gem_dependency_test.rb
View File

@@ -178,6 +178,13 @@ class GemDependencyTest < Test::Unit::TestCase
assert_equal '= 1.1', dummy_gem.version_requirements.to_s
end
def test_gem_from_directory_name_loads_specification_successfully
assert_nothing_raised do
dummy_gem = Rails::GemDependency.from_directory_name(File.join(Rails::GemDependency.unpacked_path, 'dummy-gem-g-1.0.0'))
assert_not_nil dummy_gem.specification
end
end
def test_gem_from_invalid_directory_name
assert_raises RuntimeError do
dummy_gem = Rails::GemDependency.from_directory_name('dummy-gem')