Move runtime back to the Thread.current

This commit is contained in:
José Valim
2010-07-26 19:14:24 +02:00
parent 32844cbc02
commit dd61a817de
4 changed files with 21 additions and 13 deletions

View File

@@ -34,13 +34,11 @@ module ActiveRecord
include QueryCache
include ActiveSupport::Callbacks
attr_accessor :runtime
define_callbacks :checkout, :checkin
def initialize(connection, logger = nil) #:nodoc:
@active = nil
@connection, @logger = connection, logger
@runtime = 0
@query_cache_enabled = false
@query_cache = {}
@instrumenter = ActiveSupport::Notifications.instrumenter
@@ -92,11 +90,6 @@ module ActiveRecord
false
end
def reset_runtime #:nodoc:
rt, @runtime = @runtime, 0
rt
end
# QUOTING ==================================================
# Override to return the quoted table name. Defaults to column quoting.

View File

@@ -1,13 +1,25 @@
module ActiveRecord
class LogSubscriber < ActiveSupport::LogSubscriber
def self.runtime=(value)
Thread.current["active_record_sql_runtime"] = value
end
def self.runtime
Thread.current["active_record_sql_runtime"] ||= 0
end
def self.reset_runtime
rt, self.runtime = runtime, 0
rt
end
def initialize
super
@odd_or_even = false
end
def sql(event)
connection = ActiveRecord::Base.connection
connection.runtime += event.duration
self.class.runtime += event.duration
return unless logger.debug?
name = '%s (%.1fms)' % [event.payload[:name], event.duration]
@@ -33,4 +45,4 @@ module ActiveRecord
end
end
ActiveRecord::LogSubscriber.attach_to :active_record
ActiveRecord::LogSubscriber.attach_to :active_record

View File

@@ -11,10 +11,9 @@ module ActiveRecord
def cleanup_view_runtime
if ActiveRecord::Base.connected?
connection = ActiveRecord::Base.connection
db_rt_before_render = connection.reset_runtime
db_rt_before_render = ActiveRecord::LogSubscriber.reset_runtime
runtime = super
db_rt_after_render = connection.reset_runtime
db_rt_after_render = ActiveRecord::LogSubscriber.reset_runtime
self.db_runtime = db_rt_before_render + db_rt_after_render
runtime - db_rt_after_render
else

View File

@@ -57,4 +57,8 @@ class LogSubscriberTest < ActiveRecord::TestCase
wait
assert_equal 0, @logger.logged(:debug).size
end
def test_initializes_runtime
Thread.new { assert_equal 0, ActiveRecord::LogSubscriber.runtime }.join
end
end