github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't set the hidden checkbox value if it's nil

Browse Source
This commit is contained in:
Damien Mathieu
2012-01-06 17:14:49 +01:00
committed by Carlos Antonio da Silva
parent 19be5ea877
commit defb751681
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/lib/action_view/helpers/form_helper.rb
View File

@@ -1092,7 +1092,7 @@ module ActionView
else
add_default_name_and_id(options)
end
hidden = tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"])
hidden = unchecked_value ? tag("input", "name" => options["name"], "type" => "hidden", "value" => unchecked_value, "disabled" => options["disabled"]) : ""
checkbox = tag("input", options)
(hidden + checkbox).html_safe
end

8
actionpack/test/template/form_helper_test.rb
View File

@@ -373,6 +373,14 @@ class FormHelperTest < ActionView::TestCase
)
end
def test_check_box_with_nil_unchecked_value
@post.secret = "on"
assert_dom_equal(
'<input checked="checked" id="post_secret" name="post[secret]" type="checkbox" value="on" />',
check_box("post", "secret", {}, "on", nil)
)
end
def test_check_box_with_multiple_behavior
@post.comment_ids = [2,3]
assert_dom_equal(