Optimize Range#sum only for integers [#2489]

This commit is contained in:
José Valim
2009-08-09 19:03:09 +02:00
committed by Pratik Naik
parent 1185500ff0
commit e0adfa82c0
2 changed files with 4 additions and 2 deletions

View File

@@ -113,9 +113,10 @@ module Enumerable
end
class Range #:nodoc:
# Optimize range sum to use arithmetic progression if a block is not given.
# Optimize range sum to use arithmetic progression if a block is not given and
# we have a range of numeric values.
def sum(identity=0, &block)
return super if block_given?
return super if block_given? || !(first.instance_of?(Integer) && last.instance_of?(Integer))
actual_last = exclude_end? ? (last - 1) : last
(actual_last - first + 1) * (actual_last + first) / 2
end

View File

@@ -64,6 +64,7 @@ class EnumerableTests < Test::Unit::TestCase
assert_equal 20, (1..4).sum { |i| i * 2 }
assert_equal 10, (1..4).sum
assert_equal 6, (1...4).sum
assert_equal 'abc', ('a'..'c').sum
end
def test_each_with_object