Merge pull request #1641 from sikachu/3-1-stable-render-inline

Render inline fix for 3-1-stable

actionpack/CHANGELOG

@@ -1,5 +1,7 @@
 *Rails 3.1.0 (unreleased)*
 
+* json_escape will now return a SafeBuffer string if it receives SafeBuffer string [tenderlove]
+
 * Make sure escape_js returns SafeBuffer string if it receives SafeBuffer string [Prem Sichanugrist]
 
 * Fix escape_js to work correctly with the new SafeBuffer restriction [Paul Gallagher]

actionpack/lib/action_view/template.rb

@@ -219,6 +219,9 @@ module ActionView
         method_name = self.method_name
 
         if source.encoding_aware?
+          # Avoid performing in-place mutation for SafeBuffer
+          @source = source.to_str if source.html_safe?
+
           # Look for # encoding: *. If we find one, we'll encode the
           # String in that encoding, otherwise, we'll use the
           # default external encoding.

actionpack/test/template/template_test.rb

@@ -173,5 +173,10 @@ class TestERBTemplate < ActiveSupport::TestCase
     ensure
       silence_warnings { Encoding.default_external = old }
     end
+
+    def test_render_inline_safebuffer_should_not_raise_error
+      @template = new_template("Hello".html_safe)
+      render
+    end
   end
 end