number_to_phone always return safe

This commit is contained in:
Santiago Pastorino
2010-10-17 20:42:13 -02:00
parent 2f9e880431
commit ea7db8ebc1
2 changed files with 3 additions and 5 deletions

View File

@@ -51,12 +51,9 @@ module ActionView
begin
Float(number)
is_number_html_safe = true
rescue ArgumentError, TypeError
if options[:raise]
raise InvalidNumberError, number
else
is_number_html_safe = number.to_s.html_safe?
end
end
@@ -76,7 +73,7 @@ module ActionView
number.starts_with?('-') ? number.slice!(1..-1) : number
end
str << " x #{extension}" unless extension.blank?
is_number_html_safe ? str.html_safe : str
html_escape(str)
end
# Formats a +number+ into a currency string (e.g., $13.65). You can customize the format

View File

@@ -289,7 +289,8 @@ class NumberHelperTest < ActionView::TestCase
assert number_to_percentage("asdf".html_safe).html_safe?
assert number_to_phone(1).html_safe?
assert !number_to_phone("<script></script>").html_safe?
assert_equal "&lt;script&gt;&lt;/script&gt;", number_to_phone("<script></script>")
assert number_to_phone("<script></script>").html_safe?
assert number_to_phone("asdf".html_safe).html_safe?
assert number_with_delimiter(1).html_safe?