github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Roflscaling!

Browse Source 
Don't prefix the name with attribute_. Avoids a string allocation on
read_attribute, which is a bit faster.
This commit is contained in:
Jon Leighton
2011-12-01 22:47:12 +00:00
parent 9ead4130de
commit f6b5046305
2 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
activerecord/lib/active_record/attribute_methods/primary_key.rb
View File

@@ -31,9 +31,9 @@ module ActiveRecord
if attr_name == primary_key && attr_name != 'id'
generated_attribute_methods.send(:alias_method, :id, primary_key)
generated_attribute_methods.module_eval <<-CODE, __FILE__, __LINE__
def self.attribute_id(v, attributes, attributes_cache, attr_name)
def self.id(v, attributes, attributes_cache, attr_name)
attr_name = '#{primary_key}'
send(:'attribute_#{attr_name}', attributes[attr_name], attributes, attributes_cache, attr_name)
send(attr_name, attributes[attr_name], attributes, attributes_cache, attr_name)
end
CODE
end

15
activerecord/lib/active_record/attribute_methods/read.rb
View File

@@ -30,11 +30,9 @@ module ActiveRecord
end
def undefine_attribute_methods
if base_class == self
generated_attribute_methods.module_eval do
public_methods(false).each do |m|
singleton_class.send(:undef_method, m) if m.to_s =~ /^attribute_/
end
if base_class == self && attribute_methods_generated?
column_names.each do |name|
generated_attribute_methods.singleton_class.send(:undef_method, name)
end
end
@@ -67,7 +65,7 @@ module ActiveRecord
def __temp__(v, attributes, attributes_cache, attr_name)
#{external}
end
alias_method 'attribute_#{attr_name}', :__temp__
alias_method '#{attr_name}', :__temp__
undef_method :__temp__
STR
end
@@ -110,12 +108,11 @@ module ActiveRecord
# "2004-12-12" in a data column is cast to a date object, like Date.new(2004, 12, 12)).
def read_attribute(attr_name)
attr_name = attr_name.to_s
accessor = "attribute_#{attr_name}"
methods = self.class.generated_attribute_methods
if methods.respond_to?(accessor)
if methods.respond_to?(attr_name)
if @attributes.has_key?(attr_name) || attr_name == 'id'
methods.send(accessor, @attributes[attr_name], @attributes, @attributes_cache, attr_name)
methods.send(attr_name, @attributes[attr_name], @attributes, @attributes_cache, attr_name)
end
elsif !self.class.attribute_methods_generated?
# If we haven't generated the caster methods yet, do that and