github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve code from 231d7676f7

Browse Source
This commit is contained in:
Pratik Naik
2010-05-09 12:30:45 +01:00
parent 231d7676f7
commit f75a6fec29
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
activerecord/lib/active_record/relation/batches.rb
View File

@@ -67,18 +67,16 @@ module ActiveRecord
relation = relation.except(:order).order(batch_order).limit(batch_size)
records = relation.where(primary_key.gteq(start)).all
key_value = self.primary_key.name
while records.any?
yield records
break if records.size < batch_size
last_value = records.last.send(key_value)
raise "You must include the primary key if you define a select" unless last_value.present?
records = relation.where(primary_key.gt(last_value)).all
if primary_key_offset = records.last.id
records = relation.where(primary_key.gt(primary_key_offset)).all
else
raise "Primary key not included in the custom select clause"
end
end
end