github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't use strings for callbacks, as these will be evaled. Rather use symbols, which uses a direct method dispatch.

Browse Source 
Patch by Comron Sattari. [#3429 state:resolved]
This commit is contained in:
Eloy Duran
2010-01-02 00:49:49 +01:00
parent 2171e0a1d1
commit f866ced24a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
activerecord/lib/active_record/autosave_association.rb
View File

@@ -163,8 +163,8 @@ module ActiveRecord
# guards that check if the save or validation methods have already been
# defined before actually defining them.
def add_autosave_association_callbacks(reflection)
save_method = "autosave_associated_records_for_#{reflection.name}"
validation_method = "validate_associated_records_for_#{reflection.name}"
save_method = :"autosave_associated_records_for_#{reflection.name}"
validation_method = :"validate_associated_records_for_#{reflection.name}"
force_validation = (reflection.options[:validate] == true || reflection.options[:autosave] == true)
if reflection.collection_association?