mirror of
https://github.com/github/rails.git
synced 2026-04-26 03:00:59 -04:00
Remove deprecated '_delete' option from NestedAttributes.
This commit is contained in:
@@ -264,21 +264,11 @@ module ActiveRecord
|
||||
marked_for_destruction?
|
||||
end
|
||||
|
||||
# Deal with deprecated _delete.
|
||||
#
|
||||
def _delete #:nodoc:
|
||||
ActiveSupport::Deprecation.warn "_delete is deprecated in nested attributes. Use _destroy instead."
|
||||
_destroy
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
# Attribute hash keys that should not be assigned as normal attributes.
|
||||
# These hash keys are nested attributes implementation details.
|
||||
#
|
||||
# TODO Remove _delete from UNASSIGNABLE_KEYS when deprecation warning are
|
||||
# removed.
|
||||
UNASSIGNABLE_KEYS = %w( id _destroy _delete )
|
||||
UNASSIGNABLE_KEYS = %w( id _destroy )
|
||||
|
||||
# Assigns the given attributes to the association.
|
||||
#
|
||||
@@ -375,8 +365,7 @@ module ActiveRecord
|
||||
|
||||
# Determines if a hash contains a truthy _destroy key.
|
||||
def has_destroy_flag?(hash)
|
||||
ConnectionAdapters::Column.value_to_boolean(hash['_destroy']) ||
|
||||
ConnectionAdapters::Column.value_to_boolean(hash['_delete']) # TODO Remove after deprecation.
|
||||
ConnectionAdapters::Column.value_to_boolean(hash['_destroy'])
|
||||
end
|
||||
|
||||
# Determines if a new record should be build by checking for
|
||||
|
||||
@@ -82,12 +82,6 @@ class TestNestedAttributesInGeneral < ActiveRecord::TestCase
|
||||
assert ship._destroy
|
||||
end
|
||||
|
||||
def test_underscore_delete_is_deprecated
|
||||
ActiveSupport::Deprecation.expects(:warn)
|
||||
ship = Ship.create!(:name => 'Nights Dirty Lightning')
|
||||
ship._delete
|
||||
end
|
||||
|
||||
def test_reject_if_method_without_arguments
|
||||
Pirate.accepts_nested_attributes_for :ship, :reject_if => :new_record?
|
||||
|
||||
|
||||
Reference in New Issue
Block a user